Skip to content

Add Windowed Mode to Gamescope Options #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

MuraPura
Copy link
Contributor

Adds a windowed mode to the upscaling options. Useful for really old games that open in a very tiny window due to low resolution.

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Mar 10, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MuraPura
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this configuration be used to add some flag for gamescope like it's done for the other options? https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/main/src/backend/launcher.ts#L200

or Windowed means no flag is passed? (I see that we currently pass either -f or -b but we have no option to not add one of those flags)

@MuraPura
Copy link
Contributor Author

Gamescope by default is windowed. -f and -b are flags passed to change that default behavior. To my knowledge there isn't an explicit flag to pass for windowed since that is the default to begin with.

@Etaash-mathamsetty Etaash-mathamsetty merged commit c674e04 into Heroic-Games-Launcher:main Mar 18, 2024
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants