Skip to content

[Log] Print installed winetricks packages in logs #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Feb 25, 2024

Ok, third time is the charm. I tried to implement this 2 times before and both times it was broken, but now it's fine.

This fixes #3104


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 25, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team February 25, 2024 03:19
@arielj arielj requested a review from CommandMC March 16, 2024 18:08
@arielj arielj merged commit 91cd627 into main Mar 29, 2024
@arielj arielj deleted the winetricks-in-logs branch March 29, 2024 21:41
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List components installed with Winetricks in logs
2 participants