[Fix] Caching in downloadFile
#3484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhat of a band-aid fix; ideally we'd be smarter about this caching in the first place (for example only re-downloading if the user's hardware changed)
CommandMC
requested review from
a team,
arielj,
flavioislima,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
|
I understand the fix, but why is this so important? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were looking at the birthtime of the file, which doesn't actually get updated when re-downloading (as such, nothing was ever cached).
A very quick local test suggests that this is working, but I don't have the time to properly test this on multiple systems/OSs right now.
In case this does work as-is everywhere, I've also created the pci_ids_stable_branch branch from our latest release and the two commits, ideally we'd release this ASAP as a 2.12.1.
Use the following Checklist if you have changed something on the Backend or Frontend: