Skip to content

[TECH] Add React Dev tools debug script #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Dec 8, 2023

Install the proper extension and loads it when using yarn debug:react

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:wip WIP, don't merge. label Dec 8, 2023
version "3.0.1"
resolved "https://registry.yarnpkg.com/ansi-regex/-/ansi-regex-3.0.1.tgz#123d6479e92ad45ad897d4054e3c7ca7db4944e1"
integrity sha512-+O9Jct8wf++lXxxFc4hc8LsjaSq0HFzzL7cVsw8pRDIPdjKD2mT4ytDZlLuSBZ4cLKZFXIrMGO7DbQCtMJJMKw==

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what happened with this file but there are multiple dependencies duplicated now, ansi-regex 3.0.0 and 5.0.1, camelcase 4.0.0 and 5.0.1, and others

not sure if that is correct or a conflict/merge issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. I just installed react-devtool with yarn.
Maybe we should delete yarn.lock and generate a new one?

Copy link
Collaborator

@CommandMC CommandMC Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are dependencies of the react-devtools package. There are quite a few of them, but other than that, this is nothing abnormal (it seems that they're depending on an older version of Electron, which in turn pulls in other older packages)

@CommandMC CommandMC added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:wip WIP, don't merge. labels Mar 26, 2024
@arielj
Copy link
Collaborator

arielj commented May 23, 2024

merged #3765 that replaces this PR

@arielj arielj closed this May 23, 2024
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants