Skip to content

[Mac] Allow setting the prefixes folder on Mac too #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Nov 29, 2023

This option is present only on Linux, but we should also allow users to set this on Mac for the "wines" that work with prefixes like Wine-Staging.

Currently the prefixes dir is the default ~/Games/Heroic/Prefixes/default and can't be changed.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 29, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team November 29, 2023 02:21
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but what is being shown if the selected wine is Crossover?

@arielj
Copy link
Collaborator Author

arielj commented Nov 29, 2023

Looks good, but what is being shown if the selected wine is Crossover?

This setting is shown in the general settings, it's independent of what's selected as the wine for a given game. (like in linux it's independent to games being win or native)

@flavioislima
Copy link
Member

Looks good, but what is being shown if the selected wine is Crossover?

This setting is shown in the general settings, it's independent of what's selected as the wine for a given game. (like in linux it's independent to games being win or native)

Ah ok, I misread the name of the file for the one we show on the game settings.
Should be fine then.

@flavioislima flavioislima merged commit 7d7800e into main Nov 30, 2023
@flavioislima flavioislima deleted the prefixes-dir-config-on-mac branch November 30, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants