[Tech] Skip empty arguments in sideload and frontend command launcher #3009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a rework, as discussed with @CommandMC on Discord. Turning into a draft for now. |
rdbrschf
force-pushed
the
bugfix/winecmd-empty-arguments
branch
3 times, most recently
from
6e03da6 to
d563dc5
Compare
rdbrschf
changed the title
|
v2: modified the correct location (sideloaded launch function), modified frontend update bypass code to not add spurious whitespace characters (although the actual runners should generally handle this gracefully via |
CommandMC
reviewed
Nov 7, 2023
…nt if falsy (empty, null, ...) If the additional command line arguments are unset/set to an empty string, the sideload command launcher likewise used to pass an empty argument to the launched application. While that is usually harmless, some applications try to parse this argument and (rightfully) complain and usually exit with an error. Make sure that we only pass additional arguments if they are actually set, fixing that issue. This has been encountered with Palia's launcher. While at it, also fix a log line by including additional arguments and a typo in a comment.
rdbrschf
force-pushed
the
bugfix/winecmd-empty-arguments
branch
from
d563dc5 to
40dafdf
Compare
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA. |
|
recheck |
|
Reworked this. Fixed the syntax nit by using another variable as proposed, dropped the second commit (obsolete, newer code passes update skipping mechanic in a different way to the legendary component). |
imLinguin
approved these changes
Aug 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the additional command line arguments are unset/set to an empty string, the wine command launcher will likewise pass an empty argument to the launched application.
While that is usually harmless, some applications try to parse this argument and (rightfully) complain and usually exit with an error.
Make sure that we only pass additional arguments if they are actually set, fixing that issue.
This has been encountered with Palia's launcher.
Use the following Checklist if you have changed something on the Backend or Frontend: