Skip to content

[FIX]: Multiple Amazon Games bugs #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 26, 2023
Merged

[FIX]: Multiple Amazon Games bugs #2897

merged 6 commits into from
Jul 26, 2023

Conversation

imLinguin
Copy link
Member

@imLinguin imLinguin commented Jul 25, 2023

  • Updated nile to store install size in installed.json
  • Additionally I reproduced how nile creates folder names to avoid miss matches
  • Changed how we determine if user is logged in, as username can be empty (added a fallback for login page to Unknown for that case)

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 25, 2023
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC and Nocccer and removed request for a team July 25, 2023 09:12
@imLinguin imLinguin changed the title [FIX]: show install size for amazon games [FIX]: Multiple Amazon Games bugs Jul 25, 2023
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some suggestion to use removeSpecialcharacters function instead your own.

@imLinguin imLinguin added the pr:wip WIP, don't merge. label Jul 25, 2023
@imLinguin imLinguin removed the pr:wip WIP, don't merge. label Jul 26, 2023
@imLinguin imLinguin requested review from Nocccer and CommandMC July 26, 2023 10:38
@flavioislima flavioislima merged commit c746c10 into main Jul 26, 2023
@flavioislima flavioislima deleted the feat/nile-size branch July 26, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: "Flatpak Command Not Found" Error [SteamDeck][AMAZON GAMES]
4 participants