Skip to content

Revert "[UI] Remove FSR toggle (#2842)" #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2023
Merged

Revert "[UI] Remove FSR toggle (#2842)" #2876

merged 2 commits into from
Jul 23, 2023

Conversation

imLinguin
Copy link
Member

This reverts commit 89970c5.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 21, 2023
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC and Nocccer and removed request for a team July 21, 2023 11:50
@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Jul 21, 2023 •
edited
Loading

This toggle still doesn't do anything, if we want to add it back let's make it do something first :)

FSR is already auto enabled, so setting it to 1 will not do anything

@flavioislima flavioislima merged commit ba1ab80 into main Jul 23, 2023
@flavioislima flavioislima deleted the revert_fsr_removal branch July 23, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imLinguin @Etaash-mathamsetty @flavioislima