Skip to content

[Legendary] Refresh legendary only once at boot #2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jun 3, 2023

The issue with legendary list --third-party running twice at boot causing a race condition and invalidating the auth token has been back for a while.

This PR removes the extra call to .refresh so it will now run that only once (the frontend is triggering the refresh too)

Should fix #2753


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jun 3, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team June 3, 2023 17:13
@arielj arielj changed the title Refresh legendary only once at boot [Legendary] Refresh legendary only once at boot Jun 3, 2023
@flavioislima flavioislima merged commit 94dcf75 into main Jun 4, 2023
@flavioislima flavioislima deleted the one-legendary-refresh branch June 4, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heroic logs me out after every restart of the PC
2 participants