Skip to content

[UX] Do not force focus on main window after closing game #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jun 2, 2023

This fixes #2594

We were forcing the focus on the main window after a game was closed which was not great UX.

The are many scenarios when starting a game:

  • game was started with no GUI (in this case the autofocus was already ignored)
  • game was started from the try (in this case the autofocus was already ignored)
  • game was started from the gui (the windows is back on focus after closing a game anyway since it was the last window with focus, even after removing these lines)
  • main window is minimized/close while a game is loading (in this cases the window was forced to gain focus after close, even if the user explicitly move it out of the way, not it's not)
  • sometimes a game takes a long time to actually end after exiting, if you move to another window to do something else then heroic would steal the focus after an undefined amount of time

With the current change we don't force the focus, if the window is the first screen after closing a game it still regains focus automatically anyway.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jun 2, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team June 2, 2023 11:54
Copy link
Member

@imLinguin imLinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It annoyed me a bit too

@arielj arielj changed the title Do not force focus on main window after closing game [UX] Do not force focus on main window after closing game Jun 3, 2023
@arielj arielj merged commit bc97c7d into main Jun 3, 2023
@arielj arielj deleted the do-not-auto-focus branch June 3, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove focus after game ends
2 participants