Skip to content

[Bug] Fix "no https" toggle not working #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2023
Merged

[Bug] Fix "no https" toggle not working #2755

merged 1 commit into from
Jun 8, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jun 2, 2023

This PR fixes #2721

The onClick handler was always setting this to false

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jun 2, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team June 2, 2023 03:41
@arielj arielj changed the title Fix "no https" toggle not working [Bug] Fix "no https" toggle not working Jun 3, 2023
Nocccer
Nocccer approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@imLinguin
Copy link
Member

Not sure if that applies here, but maybe we should make it clear this feature works for Epic only. GOG CDNs redirect to https automatically.

@flavioislima flavioislima merged commit ffe4b7a into main Jun 8, 2023
@flavioislima flavioislima deleted the no-https-toggle branch June 8, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nocccer Nocccer Nocccer approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking "Download games without HTTPS" does nothing
4 participants
@arielj @imLinguin @Nocccer @flavioislima