-
-
Notifications
You must be signed in to change notification settings - Fork 480
[UI] Use cover art for the most recently played game #2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Use cover art for the most recently played game #2750
Conversation
- Show cover art instead of box art for the first recently played game
@@ -106,6 +120,12 @@ | |||
padding: var(--space-xs-fixed); | |||
} | |||
|
|||
.gameCard.justPlayed > .icons { | |||
justify-content: space-between; | |||
grid-template-columns: 0.15fr 0.15fr 0.15fr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grid-template-columns: 0.15fr 0.15fr 0.15fr; | |
grid-template-columns: 1fr 1fr 1fr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we could discuss the ideal layout in Discord with the others' feedback.
- Use simple check for isJustPlayed - Use grid-column span instead to occupy grids
I think it is too much space on the button. But maybe @biliesilva can give more insights on that. |
I had tried placing the buttons in that alignment too. Yes, it looks much better. |
I've made the logo alignment look like the above screenshot. |
@redromnon can you make a version of it where you replace the play icons with a button with the text PLAY on it? Since we have more space now. |
Just replace the green play button with text while keeping the settings and update icons? |
- Change the icons alignment by placing the update icon towards the left-end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏽
Although this is not part of the Figma design, I thought of using the cover art for the just recently played game. Kind of like how several game launchers do.
This PR introduces the
justPlayed
property for theCard
interface that is set totrue
for the first game under the Recently PlayedGamesList
. Iftrue
, theGameCard
' uses game'sart_cover
as thesrc
.The covert art box occupies two grids for correctly containing the art.
Use the following Checklist if you have changed something on the Backend or Frontend: