Skip to content

[FIX] GOG download size in download manager #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2023
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented May 30, 2023

When adding GOG games to the download queue, the game size shows up as ??.

The issue is that we were passing Windows instead of windows as the platform.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team May 30, 2023 02:23
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 30, 2023
@imLinguin
Copy link
Member

Same thing is also happening for Linux native (not sure if that's intended), which is probably related to not existing linux platform in gogdl info command.
I'm unable to test Mac too

@flavioislima
Copy link
Member

Same issue on macOS. I think this was fixed already. Or was fixed and we introduced it already.

@flavioislima flavioislima changed the title Fix GOG download size in download manager [FIX] GOG download size in download manager May 30, 2023
@flavioislima flavioislima merged commit e2ceb4c into main May 30, 2023
@flavioislima flavioislima deleted the fix-gog-download-size branch May 30, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants