From 353774770e62d565ff48137bd1175bd442a50ecc Mon Sep 17 00:00:00 2001
From: Etaash Mathamsetty <etaash.mathamsetty@gmail.com>
Date: Sun, 7 May 2023 19:19:21 -0400
Subject: [PATCH 1/4] fix sideload art square and cover

---
 .../Library/components/InstallModal/SideloadDialog/index.tsx  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx b/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx
index 0542266b65..ed6238b829 100644
--- a/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx
+++ b/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx
@@ -147,9 +147,9 @@ export default function SideloadDialog({
         executable: selectedExe,
         platform: gameInfo.install?.platform ?? platformToInstall
       },
-      art_cover: imageUrl,
+      art_cover: imageUrl ? imageUrl : fallbackImage,
       is_installed: true,
-      art_square: imageUrl,
+      art_square: imageUrl ? imageUrl : fallbackImage,
       canRunOffline: true
     })
     const gameSettings = await getGameSettings(app_name, 'sideload')

From 8c6fae1c30ac03304d78e1a77d9b7758b633ed7b Mon Sep 17 00:00:00 2001
From: Etaash Mathamsetty <etaash.mathamsetty@gmail.com>
Date: Sun, 7 May 2023 19:27:57 -0400
Subject: [PATCH 2/4] bug fixes

---
 .../components/InstallModal/SideloadDialog/index.tsx   | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx b/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx
index ed6238b829..7babb2734a 100644
--- a/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx
+++ b/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx
@@ -147,9 +147,9 @@ export default function SideloadDialog({
         executable: selectedExe,
         platform: gameInfo.install?.platform ?? platformToInstall
       },
-      art_cover: imageUrl ? imageUrl : fallbackImage,
+      art_cover: imageUrl ? imageUrl : 'fallback',
       is_installed: true,
-      art_square: imageUrl ? imageUrl : fallbackImage,
+      art_square: imageUrl ? imageUrl : 'fallback',
       canRunOffline: true
     })
     const gameSettings = await getGameSettings(app_name, 'sideload')
@@ -247,7 +247,9 @@ export default function SideloadDialog({
           <div className="imageIcons">
             <CachedImage
               className={classNames('appImage', { blackWhiteImage: searching })}
-              src={imageUrl ? imageUrl : fallbackImage}
+              src={
+                imageUrl || imageUrl !== 'fallback' ? imageUrl : fallbackImage
+              }
             />
             <span className="titleIcon">
               {title}
@@ -278,7 +280,7 @@ export default function SideloadDialog({
               )}
               onChange={(e) => setImageUrl(e.target.value)}
               htmlId="sideload-image"
-              value={imageUrl}
+              value={imageUrl !== 'fallback' ? imageUrl : ''}
             />
             {!editMode && children}
             <PathSelectionBox

From 95a9f915c16e2fadd7cca7a778831dda98daf4be Mon Sep 17 00:00:00 2001
From: Etaash Mathamsetty <etaash.mathamsetty@gmail.com>
Date: Mon, 8 May 2023 06:49:33 -0400
Subject: [PATCH 3/4] Revert "bug fixes"

This reverts commit 8c6fae1c30ac03304d78e1a77d9b7758b633ed7b.
---
 .../components/InstallModal/SideloadDialog/index.tsx   | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx b/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx
index 7babb2734a..ed6238b829 100644
--- a/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx
+++ b/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx
@@ -147,9 +147,9 @@ export default function SideloadDialog({
         executable: selectedExe,
         platform: gameInfo.install?.platform ?? platformToInstall
       },
-      art_cover: imageUrl ? imageUrl : 'fallback',
+      art_cover: imageUrl ? imageUrl : fallbackImage,
       is_installed: true,
-      art_square: imageUrl ? imageUrl : 'fallback',
+      art_square: imageUrl ? imageUrl : fallbackImage,
       canRunOffline: true
     })
     const gameSettings = await getGameSettings(app_name, 'sideload')
@@ -247,9 +247,7 @@ export default function SideloadDialog({
           <div className="imageIcons">
             <CachedImage
               className={classNames('appImage', { blackWhiteImage: searching })}
-              src={
-                imageUrl || imageUrl !== 'fallback' ? imageUrl : fallbackImage
-              }
+              src={imageUrl ? imageUrl : fallbackImage}
             />
             <span className="titleIcon">
               {title}
@@ -280,7 +278,7 @@ export default function SideloadDialog({
               )}
               onChange={(e) => setImageUrl(e.target.value)}
               htmlId="sideload-image"
-              value={imageUrl !== 'fallback' ? imageUrl : ''}
+              value={imageUrl}
             />
             {!editMode && children}
             <PathSelectionBox

From c53edb9e1b2738af9b79d3956e5a19f921e0bc22 Mon Sep 17 00:00:00 2001
From: Etaash Mathamsetty <etaash.mathamsetty@gmail.com>
Date: Mon, 8 May 2023 06:53:39 -0400
Subject: [PATCH 4/4] a better fix

---
 src/frontend/screens/Library/components/GameCard/constants.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/frontend/screens/Library/components/GameCard/constants.ts b/src/frontend/screens/Library/components/GameCard/constants.ts
index 19fb197bf7..bca1996905 100644
--- a/src/frontend/screens/Library/components/GameCard/constants.ts
+++ b/src/frontend/screens/Library/components/GameCard/constants.ts
@@ -3,7 +3,7 @@ import fallbackImage from 'frontend/assets/heroic_card.jpg'
 
 export function getImageFormatting(cover: string, runner: Runner) {
   const imageBase = cover
-  if (imageBase === 'fallback') {
+  if (imageBase === 'fallback' || !cover) {
     return fallbackImage
   }
   if (runner === 'legendary') {