Skip to content

[UI] Fixes in Nord Light theme #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2023
Merged

[UI] Fixes in Nord Light theme #2687

merged 1 commit into from
May 7, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented May 6, 2023

This PR fixes 2 issues with the Nord Light theme:

Before
Winetricks dialog logs:
image

Context menu:
image

After
Winetricks:
image

Context menu:
image

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team May 6, 2023 22:00
@arielj arielj changed the title Fixes in nord light theme [UI] Fixes in Nord Light theme May 6, 2023
Etaash-mathamsetty
Etaash-mathamsetty approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit 02063d4 into main May 7, 2023
@flavioislima flavioislima deleted the fix-nord-light-context-menu branch May 7, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@imLinguin imLinguin imLinguin approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arielj @Etaash-mathamsetty @imLinguin @flavioislima