Skip to content

[FIX] Image search on Add Game Screen blocking finish button #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Apr 28, 2023

Fixes #2607

Adds a timeout of 3.5 seconds to get the image, otherwise gives up and uses the fallback.
Also keeps the field empty so people can see the placeholder that states that you can paste an URL there since some people were missing it.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 28, 2023
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nocccer Nocccer merged commit 019caee into main Apr 28, 2023
@Nocccer Nocccer deleted the fix/add_game branch April 28, 2023 12:10
@rabidcopy
Copy link

Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add games that don't have an image to automatically cache based on game title.
3 participants