Skip to content

FIX: Fix playing status (again) #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2023
Merged

FIX: Fix playing status (again) #2626

merged 3 commits into from
Apr 18, 2023

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented Apr 15, 2023 •
edited
Loading

The big refactoring PR broke this again :p
and it broke it for all runners, sideloaded or not

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Etaash-mathamsetty Etaash-mathamsetty changed the title FIX: Fix non-native sideloads (again) FIX: Fix playing status (again) Apr 15, 2023
@flavioislima flavioislima requested review from a team, arielj, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team April 15, 2023 09:47
arielj
arielj approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@flavioislima flavioislima merged commit b3ee974 into Heroic-Games-Launcher:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj arielj approved these changes

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Etaash-mathamsetty @arielj @flavioislima