Skip to content

[Fix] Verify that a valid Wine/Proton prefix exists before running any Wine command #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2022

Conversation

CommandMC
Copy link
Collaborator

This will prevent Heroic from running any Wine commands unless all files required in a Wine/Proton prefix are actually present, which will in turn prevent us from creating invalid Proton prefixes (note that this will not fix already broken Proton prefixes)

This is achieved by checking for known-required prefix files in runWineCommand. If any are missing, verifyWinePrefix is used to create / hopefully fix the prefix.
Because of that, Proton will no longer get skipped in verifyWinePrefix (even though wineboot itself doesn't actually get ran, which is fine since Proton creates the prefix itself)

If you really have to disable this check when running commands (verifyWinePrefix uses runWineCommand to create the prefix for example), pass skipPrefixCheckIKnowWhatImDoing to runWineCommand


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 3, 2022
@CommandMC CommandMC requested a review from a team November 3, 2022 21:54
@CommandMC CommandMC self-assigned this Nov 3, 2022
@CommandMC CommandMC requested review from arielj, flavioislima, Nocccer, imLinguin and redromnon and removed request for a team November 3, 2022 21:54
Copy link
Member

@imLinguin imLinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks for fixing it! 👍

@CommandMC CommandMC merged commit 8e59cfd into beta Nov 6, 2022
@CommandMC CommandMC deleted the fix/no-invalid-prefixes branch November 6, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants