[Fix] Verify that a valid Wine/Proton prefix exists before running any Wine command #1987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent Heroic from running any Wine commands unless all files required in a Wine/Proton prefix are actually present, which will in turn prevent us from creating invalid Proton prefixes (note that this will not fix already broken Proton prefixes)
This is achieved by checking for known-required prefix files in
runWineCommand
. If any are missing,verifyWinePrefix
is used to create / hopefully fix the prefix.Because of that, Proton will no longer get skipped in
verifyWinePrefix
(even thoughwineboot
itself doesn't actually get ran, which is fine since Proton creates the prefix itself)If you really have to disable this check when running commands (
verifyWinePrefix
usesrunWineCommand
to create the prefix for example), passskipPrefixCheckIKnowWhatImDoing
torunWineCommand
Use the following Checklist if you have changed something on the Backend or Frontend: