Skip to content

[Fix] offline notification text #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wbrtm
Copy link
Contributor

@wbrtm wbrtm commented Nov 2, 2022

Fixes the current offline notification string resulting in something like
OfflineRetrying in ... 5 seconds
to
Offline. Retrying in 5 seconds.

Will require adoption by translators before it shows.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also update the translation files? since this is used as reference for more accurate translations

one concern I have is that the leading . could be a bit weird for translations without much context. maybe we have to refactor this a bit to be a complete string Offline. Retrying in {{seconds}} seconds. and then use 2 different keys (one for just Offline and one for Offline. Retrying...)

@wbrtm
Copy link
Contributor Author

wbrtm commented Nov 8, 2022

Although I saw translation projects where such strings were common and translators seemed to have no problem to adopt, I thought about the same fixing this. I will add another commit, should be the cleaner solution.

@wbrtm wbrtm force-pushed the offline-notification-fix branch from 4c78e4d to 562a533 Compare November 8, 2022 18:05
@wbrtm wbrtm requested a review from arielj November 8, 2022 18:17
@flavioislima flavioislima merged commit b743326 into Heroic-Games-Launcher:beta Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants