Skip to content

Move Tools content into a menu #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 11, 2022
Merged

Move Tools content into a menu #1841

merged 8 commits into from
Oct 11, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Sep 23, 2022

This PR changes the layout of the game page to show the actions that are currently in the Tools tab in a menu triggered by a "hamburger" button on the corner. Hopefully this helps with the discoverability of the options.

Changes:

  • Moved most actions into the menu
  • Moved store logo to the bottom left
  • Moved the Requirements as a menu option and a Dialog
  • Moved Wine and WinePrefix path to the main info
  • Fixed an issue where the First/Last/Time Played was grabbing the controller focus incorrectly.

I tested also with a controller.

image
image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Sep 23, 2022
@flavioislima
Copy link
Member

@biliesilva
can you check the design and maybe add a mockup for the position of the Menu?

@biliesilva
Copy link

biliesilva commented Sep 24, 2022

Is it possible to make the hamburger menu a little less big or add an icon for options (3 dots) and also give more spacing between the lines of the text? It's easier to read with slightly larger spacing. Also, It would be nice to increase the weight of some parts of the text:
image

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good codewise and the functionality.
But I agree with Billie that we could try adding the menu in other places to see how it looks.

@arielj
Copy link
Collaborator Author

arielj commented Oct 7, 2022

I applied the suggestions, it looks like this now:
image

Any suggestion on where to put the menu button to try alternatives? I tried in other places but they looked really bad to me so I don't know what alternatives you would like to see.

@arielj
Copy link
Collaborator Author

arielj commented Oct 7, 2022

Some alternatives:
image
image
image
image

@biliesilva
Copy link

The first option is more close to the convention.

@flavioislima
Copy link
Member

I vote for the first option as well.
I noticed that the Store logo was removed from the game page, maybe we could add it again in another place, maybe with the title or at the bottom of the screen?

@arielj
Copy link
Collaborator Author

arielj commented Oct 8, 2022

I vote for the first option as well. I noticed that the Store logo was removed from the game page, maybe we could add it again in another place, maybe with the title or at the bottom of the screen?

by first option you mean the first I posted (the current code, at the top right corner) or the first alternative (the second comment that is not the current code, at the right side of the game title)?

the store logo is currently at the bottom left, I can put at the bottom right maybe, or put it back at the top right

@biliesilva
Copy link

I vote for the first option as well. I noticed that the Store logo was removed from the game page, maybe we could add it again in another place, maybe with the title or at the bottom of the screen?

by first option you mean the first I posted (the current code, at the top right corner) or the first alternative (the second comment that is not the current code, at the right side of the game title)?

the store logo is currently at the bottom left, I can put at the bottom right maybe, or put it back at the top right

I mean this one:
image

@flavioislima flavioislima merged commit cc97c6a into beta Oct 11, 2022
@flavioislima flavioislima deleted the feature/game-hamburger branch October 11, 2022 12:06
@arielj arielj mentioned this pull request Oct 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants