-
-
Notifications
You must be signed in to change notification settings - Fork 480
Move Tools
content into a menu
#1841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@biliesilva |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good codewise and the functionality.
But I agree with Billie that we could try adding the menu in other places to see how it looks.
…uncher into feature/game-hamburger
The first option is more close to the convention. |
I vote for the first option as well. |
by first option you mean the first I posted (the current code, at the top right corner) or the first alternative (the second comment that is not the current code, at the right side of the game title)? the store logo is currently at the bottom left, I can put at the bottom right maybe, or put it back at the top right |
|
This PR changes the layout of the game page to show the actions that are currently in the Tools tab in a menu triggered by a "hamburger" button on the corner. Hopefully this helps with the discoverability of the options.
Changes:
First/Last/Time Played
was grabbing the controller focus incorrectly.I tested also with a controller.
Use the following Checklist if you have changed something on the Backend or Frontend: