-
-
Notifications
You must be signed in to change notification settings - Fork 480
[UI] Show winetricks progress output and Sync-Saves output via React Dialog #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and works good too! I left some comments
….com/Heroic-Games-Launcher/HeroicGamesLauncher into feat/show-winetricks-output-frontend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just left a comment on the cleanup function if the ipcRenderer.on
I tested installing some thing and things worked as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good stuff.
Tested here with both Wine and Proton prefixes and works like charm ⚔️
simplescreenrecorder-2022-08-15_18.15.54.mp4
simplescreenrecorder-2022-08-25_21.31.41.mp4
Use the following Checklist if you have changed something on the Backend or Frontend: