Skip to content

[UI] Show winetricks progress output and Sync-Saves output via React Dialog #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 30, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Aug 15, 2022

  • Show winetricks output on frontend to let the user know if winetricks is still running or stopped working.
  • If winetricks throws an error we will show the error in frontend aswell.
simplescreenrecorder-2022-08-15_18.15.54.mp4
  • Sync-Saves also using the same React component instead electron dialog
simplescreenrecorder-2022-08-25_21.31.41.mp4

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works good too! I left some comments

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just left a comment on the cleanup function if the ipcRenderer.on

I tested installing some thing and things worked as expected

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good stuff.
Tested here with both Wine and Proton prefixes and works like charm ⚔️

@Nocccer Nocccer requested a review from arielj August 18, 2022 13:56
@Nocccer Nocccer requested a review from flavioislima August 25, 2022 19:03
@Nocccer Nocccer changed the base branch from beta to main August 25, 2022 19:03
@Nocccer Nocccer changed the title [Linux] Show winetricks progress output on frontend [Linux] Show winetricks progress output and Sync-Saves output via React Dialog Aug 25, 2022
@Nocccer Nocccer changed the title [Linux] Show winetricks progress output and Sync-Saves output via React Dialog [UI] Show winetricks progress output and Sync-Saves output via React Dialog Aug 25, 2022
@Nocccer Nocccer requested a review from imLinguin August 25, 2022 19:38
@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 25, 2022
@flavioislima flavioislima merged commit b845ce5 into main Aug 30, 2022
@flavioislima flavioislima deleted the feat/show-winetricks-output-frontend branch August 30, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
3 participants