Skip to content

Remove extra game status change when killing a game #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Aug 14, 2022

This PR fixes #1698 . The problem is better explained in the linked issue but basically, when killing a game using the (x) button in the library, the libraryStatus global state got corrupted because of the line I'm now removing.

This line is not used when killing a game in the Game Page component so I understand it's safe to remove and it fixes the problem.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 14, 2022
@arielj arielj changed the title Remove game status change when killing a game Remove extra game status change when killing a game Aug 14, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably forgot to remove that line on a previous refactoring.

@flavioislima flavioislima merged commit 6cf604f into main Aug 17, 2022
@flavioislima flavioislima deleted the fixes/play-button-in-library branch August 17, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Play buttons stuck in the Play state
2 participants