Skip to content

[Tech] Updated GOGDL to fix DOSBOX Games #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Jun 13, 2022

Need to test this build on all 3 platforms before merging.

Games tested with WINE-GE:

  • Tyrian 2000
  • Ultima IV
  • Ultima II
  • BioMenace
  • Elders Scrolls Arena
  • Elders Scrolls Daggerfall

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added pr:testing This PR is in testing, don't merge. pr:ready-for-review Feature-complete, ready for the grind! :P labels Jun 13, 2022
@flavioislima
Copy link
Member Author

@imLinguin it seems the setup it's not working with Proton, I believe this started with the latest refactors.
It shows:
/bin/sh: line 1: /home/flavio/.local/share/Steam/steamapps/common/Proton: No such file or directory

If the setup is made using wine and then changing to proton makes it works.

@imLinguin
Copy link
Member

imLinguin commented Jun 13, 2022

I believe as a workaround we can add quotes around the binary in place it fails. I was going to refactor whole thing to use runWineCommand either way.

@flavioislima
Copy link
Member Author

Not related but ScummVM for windows games are not working as well, could be a similar issue?

@imLinguin
Copy link
Member

What isn't working in that case? scummVM failing to start or something else?

@flavioislima
Copy link
Member Author

Tested with Beneath a Steel Sky. The ScummVM starts but then closes without starting the game. Similar to what was happening with the dosbox games.

this is the Log:

Error Log:

wineserver: using server-side synchronization.

wine: Using setpriority to control niceness in the [-11,11] range

002c:fixme:winediag:LdrInitializeThunk wine-staging 7.0 is a testing version containing experimental patches.

002c:fixme:winediag:LdrInitializeThunk Please mention your exact version when filing bug reports on winehq.org.

007c:fixme:imm:ImeSetActiveContext (0x4803d0, 0): stub

007c:fixme:imm:ImmReleaseContext (0000000000010020, 00000000004803D0): stub

010c:fixme:imm:ImeSetActiveContext (0x4403d0, 1): stub

010c:fixme:imm:ImmReleaseContext (0000000000020068, 00000000004403D0): stub

0024:fixme:thread:GetThreadUILanguage : stub, returning default language.

0024:fixme:pulse:pulse_channel_map_to_channel_mask Unhandled channel aux0

0024:fixme:pulse:pulse_channel_map_to_channel_mask Unhandled channel aux1

0024:fixme:imm:ImmReleaseContext (00010084, 02C60030): stub

0024:fixme:msctf:ThreadMgr_ActivateEx Unimplemented flags 0x4

0024:fixme:imm:ImeSetCompositionString PROBLEM: This only sets the wine level string

0024:fixme:imm:ImeSetCompositionString Reading string unimplemented

0024:fixme:imm:NotifyIME NI_CLOSECANDIDATE

0024:fixme:imm:ImeSetActiveContext (0x2c60030, 1): stub

0024:fixme:ntdll:NtQuerySystemInformation info_class SYSTEM_PERFORMANCE_INFORMATION

0128:fixme:d3d:state_linepattern_w Setting line patterns is not supported in OpenGL core contexts.

wine: Read access denied for device L"\\??\\Z:\\", FS volume label and serial are not available.

0024:fixme:shell:propertystore_SetValue (02B22D90)->(01944AE8 028FA738): stub

0024:fixme:shell:propertystore_Commit (02B22D90): stub

0024:fixme:shell:SHAddToRecentDocs Unsupported flags: 6

012c:fixme:d3d:state_linepattern_w Setting line patterns is not supported in OpenGL core contexts.

0024:fixme:explorerframe:taskbar_list_SetProgressState iface 029DD1B0, hwnd 00010084, flags 4 stub!

0024:fixme:explorerframe:taskbar_list_SetProgressValue iface 029DD1B0, hwnd 00010084, ullCompleted 1, ullTotal 1 stub!

0024:fixme:imm:ImeSetCompositionString PROBLEM: This only sets the wine level string

0024:fixme:imm:ImeSetCompositionString Reading string unimplemented

0024:fixme:imm:NotifyIME NI_CLOSECANDIDATE

Game Log:

Using configuration file: ..\beneath.ini

Launch command: ['/home/flavio/.config/heroic/tools/wine/Wine-GE-Proton7-15/bin/wine', '/mnt/hdd/Games/Heroic/Beneath a Steel Sky/scummvm/scummvm.exe', '-c', '..\\beneath.ini', 'beneath']


@imLinguin
Copy link
Member

I remember now, there is a setup instruction to write that .ini file. I think it's not working properly in Heroic.

@flavioislima
Copy link
Member Author

Well, the .ini file is there.

@imLinguin
Copy link
Member

What about the contents? Is it containing the data provided in script instruction?

@flavioislima
Copy link
Member Author

ini:
image
info:
image

Game page (Game is Free btw:
https://gog.com/en/game/beneath_a_steel_sky

@imLinguin
Copy link
Member

The instructions are in .script file. I'll be able to test the game myself tomorrow.

@flavioislima flavioislima merged commit 89b0fdc into beta Jun 13, 2022
@flavioislima flavioislima deleted the fix/dosbox_fixes branch June 13, 2022 20:08
flavioislima added a commit that referenced this pull request Jun 15, 2022
* [Tech] Updated GOGDL to fix DOSBOX Games

* chore: lint
flavioislima added a commit that referenced this pull request Jun 15, 2022
* [Fix] Setup GOG games with Proton + ScummVM patch (#1472)

* [Fix] ScummVM windows games on linux

* fix: setup gog games with proton

* [Tech] Updated GOGDL to fix DOSBOX Games (#1469)

* [Tech] Updated GOGDL to fix DOSBOX Games

* chore: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P pr:testing This PR is in testing, don't merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants