Skip to content

Pass SDL list as multiple arguments #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Pass SDL list as multiple arguments #1443

merged 1 commit into from
Jun 10, 2022

Conversation

CommandMC
Copy link
Collaborator

Another issue that was originally caused by the launch refactor. Seems to work fine, but I could only try it for one game

Something else I've noticed: The install progress seems to start at 45% for Fortnite for some reason? Legendary is reporting it correctly


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added pr:testing This PR is in testing, don't merge. pr:ready-for-review Feature-complete, ready for the grind! :P labels Jun 6, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@CommandMC CommandMC added pr:ready-to-merge This PR is fully ready for merge. and removed pr:testing This PR is in testing, don't merge. pr:ready-for-review Feature-complete, ready for the grind! :P labels Jun 10, 2022
@arielj
Copy link
Collaborator

arielj commented Jun 10, 2022

it was confirmed by a user on discord that this PR fixes the sdl problem for them, I'm merging this

@arielj arielj merged commit 4cdf215 into main Jun 10, 2022
@arielj arielj deleted the fix/pass-sdl-properly branch June 10, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants