Change Game Language

[arielj]

This PR adds the feature to set the game language through Heroic for the games that support it.

Each game now has a Preferred Language setting:

Users can set a language code to pass as the --language flag to legendary.

Is left empty, the preferred language will fallback to Heroic's language configuration to mimic Epic Games Launcher's behavoir.

This fixes #1391 and fixes #1432

I only know of those 2 games that support this setting (Prey and Wolfenstein The New Order), I tested this with Prey. I couldn't find any place where I could know if a game should/shouldn't support this, I found no flags anywhere in the json files.

Also, I understand there's no equivalent flag for GOG games, so I just implemented this for Epic games, I'm not sure if this should be hidden when the game is from GOG or if there's actually some flag for this (I'll ask over discord). I this this can be reviewed anyway?

---

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[flavioislima]

LGTM! 👍🏽

[JakobDev]

I personally would prefer a DropDown Menu instead of a Textbox.

[arielj]

I personally would prefer a DropDown Menu instead of a Textbox.

I thought about that, but the problem is that we would have to add all possible languages in a select box, and it would be a pretty long select (you can't ignore any possible languages because you don't know which ones the games will support, I don't know what would be a safe list of languages to use)

[JakobDev]

Probably adding a other element in the List would be a solution. If you selected that, the Inputfield appears. I don't know, if that easily possible. The problem with the current solution is, that average Users which are not interested in technic may not know the correct language code or what that word even means.

[arielj]

Probably adding a other element in the List would be a solution. If you selected that, the Inputfield appears. I don't know, if that easily possible. The problem with the current solution is, that average Users which are not interested in technic may not know the correct language code or what that word even means.

One comment though, the logic is that it will default to Heroic's language, so for most users they'll probable never have to deal with this configuration if they set the language of Heroic to their preferred language, this is more like an advanced feature already to override heroic's language for the game.

I wonder how often a user would want a language different than the une they set heroic to

[flavioislima]

To be honest, I think we should not have the Input. First, it doesn't work for all games, second, will be one more option and this might be confusing to some people.
And third, the game will use heroic language so the person just need to change heroic language to make it work.
I think would be better to remove it. What do you think?

[arielj]

To be honest, I think we should not have the Input. First, it doesn't work for all games, second, will be one more option and this might be confusing to some people. And third, the game will use heroic language so the person just need to change heroic language to make it work. I think would be better to remove it. What do you think?

maybe put it in the advanced section? I'm thinking what if you want your game in a language that is not supported by heroic? then you won't be able to set it anywhere and the game will fallback to heroic's language

[arielj]

well now I'm thinking, if we support all languages already supported by EGL then I imagine games already know those are the options to support by this config, and then we can just do that and remove the intput

I just don't want to exclude languages without knowing if that's going to be a problem

[flavioislima]

Hmm, ok then put on advanced 👍

[arielj]

Hmm, ok then put on advanced +1

hmmm I just noticed we don't have an Advanced settings section for games settings, it feels too much to add a new section just for it, maybe I can put it at the end of the current section to make it less important?

[flavioislima]

Ok

[leillo1975]

Thanks a lot!