-
-
Notifications
You must be signed in to change notification settings - Fork 480
[UI/UX] Improve error handling on BE and FE #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think I am done with this one, check it out when you have the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a lot of try-catch blocks, you're not logging the actual error
at all. Might be helpful to have that, to more easily pinpoint what exactly went wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all it takes to check for MemoryError
on install
…uncher into fix/1354
I'd say showing a dialog if a legendary command failed is fine in general, no need to remove that |
Yes, I'm not removing it. But leaving it there is causing the error dialog to appear twice because we already use the log error in other places now. I will test more tomorrow. And also implementing the error handler for the issue that Ariel opened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, now we just gotta find out why the test is failing
Some things in NodeJS makes me crazy. |
One thing that makes finding errors like that easier is keeping your commits very small. It also keeps everything organized and the number of commits doesn't matter since they're all gonna get squashed at the end anyways |
@CommandMC runtime was missing for me since #1359 was merged, so I sent a new commit to this PR to use the |
Works fine on my PopOS VM |
Also Trying to fix #1354 #1360 #1347 #1371
info
commandJSON.parse()
to handle corrupted JSON files that makes Heroic not load, even if there is a damn comma by the end of the file.ErrorHandler
to deal with credentials expired for both GOG and Legendary. Let me know if I forgot some.electron-store
calls that could make Heroic hangs on start.Use the following Checklist if you have changed something on the Backend or Frontend: