Allow for separate library refreshes #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron/main.ts
Outdated
| ipcMain.handle('checkGameUpdates', async () => { | ||
| const legendaryUpdates = await LegendaryLibrary.get().listUpdateableGames() | ||
| const gogUpdates = await GOGLibrary.get().listUpdateableGames() | ||
| ipcMain.handle('checkGameUpdates', async (event, libraries) => { |
There was a problem hiding this comment.
I believe you should receive a Runner here and then depending on the Runner you call the right one.
Use a switch to make it more scalable. :)
There was a problem hiding this comment.
could also have a full parameter to refresh all libraries
|
I believe for libraries instead of |
flavioislima
added
the
pr:ready-for-review
flavioislima
approved these changes
May 25, 2022
connercsbn
added a commit
to connercsbn/HeroicGamesLauncher
that referenced
this pull request
May 25, 2022
…Launcher#1356)" This reverts commit 37cdf7e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch, addressing #1320, adds an additional string[] parameter to GlobalState.refresh and checkGameUpdates, allowing you to update just one library at a time.
Launching still refreshes both libraries, but logging in or clicking the refresh button in a library only refreshes the corresponding library.
The way I did it, there's some repeated code. There's probably a better way of doing it, especially as more libraries are added, but for now this was the best I could do. Let me know if you have a better idea and I'll happily rewrite it.
Use the following Checklist if you have changed something on the Backend or Frontend: