Skip to content

fix: fetch metadata fail #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: fetch metadata fail #605

merged 1 commit into from
Nov 8, 2024

Conversation

andreabadesso
Copy link
Contributor

Acceptance Criteria

  • Fetch token metadata is failing because we don't have serverInfo when on the wallet-service facade
  • We should use the network from networkSettings

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso changed the base branch from master to release-candidate November 8, 2024 12:44
@tuliomir tuliomir added the bug Something isn't working label Nov 8, 2024
@andreabadesso andreabadesso merged commit 23bc594 into release-candidate Nov 8, 2024
1 check passed
@andreabadesso andreabadesso deleted the fix/fetch-metadata-fail branch November 8, 2024 14:20
@tuliomir tuliomir mentioned this pull request Nov 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliomir tuliomir tuliomir approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@r4mmer r4mmer r4mmer approved these changes

Assignees

@andreabadesso andreabadesso

Labels
bug Something isn't working
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreabadesso @tuliomir @pedroferreira1 @r4mmer