Skip to content

fix: session request queue #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: session request queue #566

merged 1 commit into from
Sep 13, 2024

Conversation

andreabadesso
Copy link
Contributor

@andreabadesso andreabadesso commented Sep 13, 2024 •
edited
Loading

Acceptance Criteria

  • We should use actionChannel to keep a queue of WC_SESSION_REQUEST actions
  • We should stop using takeLeading as it will skip actions
  • We should be able to process requests in series

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Sep 13, 2024
@andreabadesso andreabadesso added the enhancement New feature or request label Sep 13, 2024
@andreabadesso andreabadesso changed the base branch from master to hathorplay-base-release September 13, 2024 21:34
@andreabadesso andreabadesso force-pushed the fix/session-request-queue branch 6 times, most recently from 90c0477 to 5014c36 Compare September 13, 2024 22:08
@andreabadesso andreabadesso force-pushed the fix/session-request-queue branch from 5014c36 to 1dab861 Compare September 13, 2024 22:09
@andreabadesso andreabadesso merged commit ddd899f into hathorplay-base-release Sep 13, 2024
@andreabadesso andreabadesso deleted the fix/session-request-queue branch September 13, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbrogli msbrogli msbrogli approved these changes

@tuliomir tuliomir tuliomir approved these changes

@pedroferreira1 pedroferreira1 Awaiting requested review from pedroferreira1 pedroferreira1 is a code owner

Assignees

@andreabadesso andreabadesso

Labels
enhancement New feature or request
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreabadesso @msbrogli @tuliomir