Promote APIQuotaAdjusterSettings (Gemini/MCP-driven) #4812
Conversation
yuwenma
force-pushed
the
APIQuotaAdjusterSettings
branch
2 times, most recently
from
28f523e to
69ec05e
Compare
|
|
||
| import ( | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| refv1beta1 "github.com/GoogleCloudPlatform/k8s-config-connector/apis/refs/v1beta1" | ||
| "github.com/GoogleCloudPlatform/k8s-config-connector/pkg/apis/k8s/v1alpha1" |
There was a problem hiding this comment.
we already have conditions for both alpha and beta, they are the same
| @@ -12,13 +12,13 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package v1alpha1 | |||
| package v1beta1 | |||
There was a problem hiding this comment.
This is awesome - a simple file move!
| @@ -124,8 +124,8 @@ func (a *apiQuotaAdjusterSettingsAdapter) Find(ctx context.Context) (bool, error | |||
| // Create is not supported for QuotaAdjusterSettings. This resource is managed by GCP implicitly. | |||
There was a problem hiding this comment.
We might want to say something like "this function should not be reachable, because Find always returns an object"
| @@ -27,7 +27,7 @@ import ( | |||
|
|
|||
| gcp "cloud.google.com/go/cloudquotas/apiv1beta" | |||
| pb "cloud.google.com/go/cloudquotas/apiv1beta/cloudquotaspb" | |||
| krm "github.com/GoogleCloudPlatform/k8s-config-connector/apis/cloudquota/v1alpha1" | |||
| cloudquotav1beta1 "github.com/GoogleCloudPlatform/k8s-config-connector/apis/cloudquota/v1beta1" | |||
There was a problem hiding this comment.
Nit: so the reason we call it krm and not cloudquotav1alpha1 is because that way when we change the import we don't have to change the code.
Do you want to add a note to GEMINI.md for next time? :-)
| @@ -173,6 +173,10 @@ issues for {{product_name_short}}. | |||
| <td><a href="/cloud-build/docs/">{{builder_name}}</a></td> | |||
| <td><a href="/config-connector/docs/reference/resource-docs/cloudbuild/cloudbuildworkerpool.md">CloudBuildWorkerPool</a></td> | |||
| </tr> | |||
| <tr> | |||
| <td><a href="/quotas/docs/">Cloud Quotas</a></td> | |||
There was a problem hiding this comment.
Do we care about alphabetical order here?
I do wonder if we could generate this file in future...
There was a problem hiding this comment.
I'll leave this to the next PR. The reference generator really needs a big change.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Nice work!
💯 |
|
New changes are detected. LGTM label has been removed. |
yuwenma
force-pushed
the
APIQuotaAdjusterSettings
branch
from
1e6f655 to
fddef71
Compare
yuwenma
force-pushed
the
APIQuotaAdjusterSettings
branch
from
10282e7 to
edda00c
Compare
yuwenma
force-pushed
the
APIQuotaAdjusterSettings
branch
from
edda00c to
dc08715
Compare
|
/hold cancel resolved comments. It also contains the bug fix in the doc generator #4815 |
(This is the pure Gemni-cli/MCP generated PR)
This is the first resource in candidates.json (with
apiVersion=true). It means it has full API coverage, and it is ready for Beta without additional API, controller or test changes.Notes:
cloudquotaservice contains another alpha API that is not ready to promote, this introduces two api imports (v1alpha1 and v1beta1) to controller and mapper, thus the imports are distinguished specifically.make read-prrequires beta resource to has google reference doc. we should split the process, and improve according to Our docs should be more GitHub compatible #4791