Skip to content

feat(new server): Palworld #4449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jan 21, 2024

Conversation

PlayMTL
Copy link
Contributor

@PlayMTL PlayMTL commented Jan 19, 2024

Description

This is the current standing of the implementation of the new server Palworld. Before merging, i would like to squash my commits :)

Fixes #4448

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@PlayMTL PlayMTL changed the base branch from master to develop January 19, 2024 18:29
@PlayMTL PlayMTL changed the title [WIP} Add new server "palworld" [WIP] Add new server "palworld" Jan 19, 2024
@dgibbs64 dgibbs64 changed the title [WIP] Add new server "palworld" [WIP] feat(new server): Palworld Jan 19, 2024
@dgibbs64 dgibbs64 self-requested a review January 19, 2024 18:39
@dgibbs64 dgibbs64 added this to the v24.1.0 milestone Jan 19, 2024
fn_info_game_pw() {
servername="${selfname:-"NOT SET"}"
port="${port:-"0"}"
maxplayers="${players:-"0"}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxplayers="${maxplayers:-"0"}"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxplayers="${maxplayers:-"0"}"

@Thundernerd
Copy link

@PlayMTL don't forget to request a re-review once you've fixed everything that was requested, otherwise the reviewers might not see it.


## Server Parameters | https://docs.linuxgsm.com/configuration/start-parameters#additional-parameters
## Game Server Docs | https://tech.palworldgame.com/dedicated-server-guide#linux
startparameters="-EpicApp=PalServer -port=${port} -players=${players} -useperfthreads -NoAsyncLoadingThread -UseMultithreadForDS -servername='${servername}' -serverpassword=${serverpassword} -adminpassword=${adminpassword}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxplayers

## Predefined Parameters | https://docs.linuxgsm.com/configuration/start-parameters
ip="0.0.0.0"
port="8211"
players="32"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxplayers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i decided to remove the startup arguments as much as possible. server now takes settings from the config file.

{
fn_port "header"
fn_port "Game" port udp
fn_port "Steam" steamport udp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that port we have no info on shoud be called "Unknown"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, i renamed the whole var to unknowport to keep it align

@PlayMTL
Copy link
Contributor Author

PlayMTL commented Jan 21, 2024

I think that's it now. There are some workarounds included, because the gameserver is a bit special...
It doesn't like emtpy password strings as startparameter or has problems, if there are set different ports & ips in startup parameters & config file.

@PlayMTL PlayMTL requested review from h3o66 and dgibbs64 January 21, 2024 10:50
@PlayMTL PlayMTL changed the title [WIP] feat(new server): Palworld feat(new server): Palworld Jan 21, 2024
@AedDev
Copy link

AedDev commented Jan 21, 2024

Would be great if this PR makes it today! :)

@BlackDahlia313
Copy link

the gameserver is a bit special...

no lie detected

@JamsRepos
Copy link

JamsRepos commented Jan 21, 2024

@dgibbs64 I hate to apply pressure but is there any plans of this being merged soon? As I know there's a large influx to this game currently and i'm sure people want to get ahead on hosting their servers and using the existing infrastructure of LinuxGSM would be a massive positive.

@dgibbs64 dgibbs64 merged commit 70fd6f4 into GameServerManagers:develop Jan 21, 2024
dgibbs64 added a commit that referenced this pull request Jan 21, 2024
* add palworld

* add palworld

* add palworld to ubuntu

* add server to serverlist

* rework _default.cfg for pwserver

* fix servercfgdir for palworld

* edit _default.cfg for pwserver

* first try info_game.sh

* debug info_game.sh

* update info_game.sh

* update info_game.sh

* update info_game.sh

* add package check for rhel, rocky, debian & ubuntu

* add details port info

* add details port change

* improve _default.cfg for pwserver

* improve _default.cfg for pwserver

* fix issues mentioned in pr

* change servername parameter for pwserver

* add: steamport var for Palworld

* fix: info_game for palworld

* change: load palworld settings from serverconfig file & change unknow port

* update ports info

* change to binary file from .sh

prevents issues with ss command

---------

Co-authored-by: Daniel Gibbs <[email protected]>
add palworld game icon

add missing pw
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants