-
Notifications
You must be signed in to change notification settings - Fork 7
Breaking changes in upgrading bootstrap #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like:
This seems to have fixed problems 1, 2, and 4 above, but not 3. |
… way of referencing bootstrap-icons outside of the stylesheet URL I put in the src/index.html file
… way of referencing bootstrap-icons outside of the stylesheet URL I put in the src/index.html file
I fixed the 3rd issue from above, but we'll have to look at a better way of referencing bootstrap-icons outside of the stylesheet URL I put in the src/index.html file (which references the http URL directly). Perhaps we could use the bootstrap-icons npm library? |
@hatfieldjm4 I pushed an update to fix the 3rd issue about an hour or so ago. I added the bootstrap-icon library as an npm package and referenced it in the angular.json file to be able t be used throughout the app |
@joshsjurik Ah, beat me to it! Sorry I missed that PR. Thanks so much, Josh. |
…lso had to handle SetIterator error by creatings a typings.d.ts file in src folder using instructions here: mozilla/pdf.js#18867
We received an alert that we need to upgrade Bootstrap. I updated stage.ea.gsa.gov to the latest version, but there were some issues that need to be addressed:
The sidenav doesn't expand when you click any of the titles. For example, when you hover over the sidenav, it expands outward (to the right) as it should, but when you try to click on "GSA Enterprise", it does not expand downward to reveal the links.The topnav ("GEAR Navigation" and "Contact/Feedback") buttons do not expandWhen you view a report, the table's icons do not show up properly. The blue background is there, but the icons themselves do not appear. The individual functions are still clickable and still function as expected, though.We'll need to address a better way of doing this.When you have a modal open, if you try to click the "x" at the top right, it will not close the modal. Clicking away from the modal does still work, though.The text was updated successfully, but these errors were encountered: