Skip to content

Breaking changes in upgrading bootstrap #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hatfieldjm4 opened this issue Feb 19, 2025 · 4 comments
Open

Breaking changes in upgrading bootstrap #602

hatfieldjm4 opened this issue Feb 19, 2025 · 4 comments
Assignees
Labels
Priority #1 This issue should be prioritized over other issues and resolved as quickly and correctly as possible

Comments

@hatfieldjm4
Copy link
Collaborator

hatfieldjm4 commented Feb 19, 2025

We received an alert that we need to upgrade Bootstrap. I updated stage.ea.gsa.gov to the latest version, but there were some issues that need to be addressed:

  1. The sidenav doesn't expand when you click any of the titles. For example, when you hover over the sidenav, it expands outward (to the right) as it should, but when you try to click on "GSA Enterprise", it does not expand downward to reveal the links.
  2. The topnav ("GEAR Navigation" and "Contact/Feedback") buttons do not expand
  3. When you view a report, the table's icons do not show up properly. The blue background is there, but the icons themselves do not appear. The individual functions are still clickable and still function as expected, though. We'll need to address a better way of doing this.
  4. When you have a modal open, if you try to click the "x" at the top right, it will not close the modal. Clicking away from the modal does still work, though.
@hatfieldjm4 hatfieldjm4 added the Priority #1 This issue should be prioritized over other issues and resolved as quickly and correctly as possible label Feb 19, 2025
@hatfieldjm4
Copy link
Collaborator Author

hatfieldjm4 commented Feb 19, 2025

It looks like:

  • "data-toggle" needs to change to "data-bs-toggle"
  • "data-dismiss" needs to change to "data-bs-dismiss"
  • "data-backdrop" needs to change to "data-bs-backdrop"
  • "data-keyboard" needs to change to "data-bs-keyboard"
  • "data-trigger" needs to change to "data-bs-trigger"
  • "data-placement" needs to change to "data-bs-placement"
  • "data-html" needs to change to "data-bs-html"
  • "data-content" needs to change to "data-bs-content"
  • "data-delay" needs to change to "data-bs-delay"
  • "data-parent" needs to change to "data-bs-parent"
  • "data-target" needs to change to "data-bs-target"

This seems to have fixed problems 1, 2, and 4 above, but not 3.
I created the bootstrap5-upgrade branch to save the work I have so far.

hatfieldjm4 added a commit that referenced this issue Feb 20, 2025
… way of referencing bootstrap-icons outside of the stylesheet URL I put in the src/index.html file
hatfieldjm4 added a commit that referenced this issue Feb 20, 2025
… way of referencing bootstrap-icons outside of the stylesheet URL I put in the src/index.html file
@hatfieldjm4
Copy link
Collaborator Author

I fixed the 3rd issue from above, but we'll have to look at a better way of referencing bootstrap-icons outside of the stylesheet URL I put in the src/index.html file (which references the http URL directly). Perhaps we could use the bootstrap-icons npm library?

@joshsjurik
Copy link
Collaborator

@hatfieldjm4 I pushed an update to fix the 3rd issue about an hour or so ago. I added the bootstrap-icon library as an npm package and referenced it in the angular.json file to be able t be used throughout the app

@hatfieldjm4
Copy link
Collaborator Author

@joshsjurik Ah, beat me to it! Sorry I missed that PR. Thanks so much, Josh.

hatfieldjm4 added a commit that referenced this issue Mar 25, 2025
…lso had to handle SetIterator error by creatings a typings.d.ts file in src folder using instructions here: mozilla/pdf.js#18867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority #1 This issue should be prioritized over other issues and resolved as quickly and correctly as possible
Projects
Status: Backlog
Development

No branches or pull requests

2 participants