diff --git a/src/libs/TransactionPreviewUtils.ts b/src/libs/TransactionPreviewUtils.ts index efa97350c919..d9a9aca6ffd3 100644 --- a/src/libs/TransactionPreviewUtils.ts +++ b/src/libs/TransactionPreviewUtils.ts @@ -225,10 +225,6 @@ function getTransactionPreviewTextAndTranslationPaths({ isPreviewHeaderTextComplete = true; } - if (shouldShowRBR && transaction) { - isPreviewHeaderTextComplete = true; - } - if (!isPreviewHeaderTextComplete) { if (hasViolationsOfTypeNotice && transaction && !isReportApproved({report: iouReport}) && !isSettled(iouReport?.reportID)) { previewHeaderText.push(dotSeparator, {translationPath: 'violations.reviewRequired'}); diff --git a/tests/unit/TransactionPreviewUtils.test.ts b/tests/unit/TransactionPreviewUtils.test.ts index 987d6edb3fc4..7441112dd22c 100644 --- a/tests/unit/TransactionPreviewUtils.test.ts +++ b/tests/unit/TransactionPreviewUtils.test.ts @@ -2,6 +2,7 @@ import {buildOptimisticIOUReport, buildOptimisticIOUReportAction} from '@libs/Re import {createTransactionPreviewConditionals, getTransactionPreviewTextAndTranslationPaths} from '@libs/TransactionPreviewUtils'; import {buildOptimisticTransaction} from '@libs/TransactionUtils'; import CONST from '@src/CONST'; +import * as ReportUtils from '@src/libs/ReportUtils'; const basicProps = { iouReport: buildOptimisticIOUReport(123, 234, 1000, '1', 'USD'), @@ -118,6 +119,18 @@ describe('TransactionPreviewUtils', () => { const result = getTransactionPreviewTextAndTranslationPaths(functionArgs); expect(result.previewHeaderText).toContainEqual({translationPath: 'iou.canceled'}); }); + + it('should include "Approved" in the preview when the report is approved, regardless of whether RBR is shown', () => { + const functionArgs = { + ...basicProps, + iouReport: {...basicProps.iouReport, stateNum: CONST.REPORT.STATE_NUM.APPROVED, statusNum: CONST.REPORT.STATUS_NUM.APPROVED}, + shouldShowRBR: true, + }; + jest.spyOn(ReportUtils, 'isPaidGroupPolicyExpenseReport').mockReturnValue(true); + const result = getTransactionPreviewTextAndTranslationPaths(functionArgs); + + expect(result.previewHeaderText).toContainEqual({translationPath: 'iou.approved'}); + }); }); describe('createTransactionPreviewConditionals', () => {