Skip to content

refactor(storybook): refactor tooltip simple story interface #9538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aPreciado88
Copy link
Contributor

Related Issue: #9537

Summary

Refactors the interface within tooltip.stories.ts to use props from the component's class.

@aPreciado88 aPreciado88 requested a review from a team as a code owner June 7, 2024 19:48
@aPreciado88 aPreciado88 added this to the 2024-06-25 - Jun Release milestone Jun 7, 2024
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jun 7, 2024
@aPreciado88 aPreciado88 added pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing. and removed refactor Issues tied to code that needs to be significantly reworked. pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 7, 2024
@aPreciado88 aPreciado88 merged commit 8b80757 into main Jun 7, 2024
14 checks passed
@aPreciado88 aPreciado88 deleted the aPreciado88/9537-refactor-tooltip-simple-story-interface branch June 7, 2024 20:55
benelan added a commit that referenced this pull request Jun 10, 2024
…orkflow

* origin/main: (26 commits)
  revert: refactor: add simpler `componentFocusable` util (deprecates `LoadableComponent`) (#9515)
  chore(linting): enable selector-pseudo-element-colon-notation rule (#9518)
  refactor(storybook): refactor tooltip simple story interface (#9538)
  refactor(dom): consolidate transition/animation waiting utils (#9341)
  refactor(storybook): build storybook simple story args interfaces using component class (#9457)
  chore: release next
  fix(block): add accessible label for slotted controls (#9502)
  feat(action-bar, action-pad): add expandLabel and collapseLabel to messages (#9497)
  chore: release next
  feat(action-menu, combobox, dropdown, input-date-picker, popover): allow logical placements for flipPlacements property. #8825 (#9490)
  fix(popover): correct border radius on close button (#9485)
  fix(list-item): hide nested list items by default (#9474)
  refactor: move component types into component specific interfaces files (#9527)
  chore: release next
  fix(alert): pause auto-close alert when link focused (#9503)
  refactor(storybook): consolidate storybook and component types (#9500)
  refactor(calcite-block-section,calcite-card): consolidate interfaces imports (#9517)
  chore: release next
  fix(block-section): restore block toggling when clicking on the header switch (#9472)
  chore: release next
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants