test(input-date-picker): add test for no longer closing date-picker when using arrow and page keys. #9097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
anveshmekala/9062-fix-date-picker-arrow-key-focus
to
main
April 10, 2024 19:35
anveshmekala
added
bug
anveshmekala
added
pr ready for visual snapshots
|
@anveshmekala I'm only seeing changes to a test in this PR. |
anveshmekala
changed the title
jcfranco
requested changes
Apr 16, 2024
|
|
||
| await page.keyboard.press("PageDown"); | ||
| await page.waitForChanges(); | ||
| calendar = await page.find(`calcite-input-date-picker >>> .${CSS.calendarWrapper}`); |
There was a problem hiding this comment.
This selector is used frequently, can you store it in a local variable and reuse?
| await page.keyboard.press("Enter"); | ||
| await page.waitForChanges(); | ||
| calendar = await page.find(`calcite-input-date-picker >>> .${CSS.calendarWrapper}`); | ||
| expect(await calendar.isVisible()).toBe(false); |
There was a problem hiding this comment.
Could you add finer-grained assertions on the month navigation? It looks like this is only asserting that the calendar is displayed. Applies to the test below.
| await page.waitForChanges(); | ||
| calendar = await page.find(`calcite-input-date-picker >>> .${CSS.calendarWrapper}`); | ||
| expect(await calendar.isVisible()).toBe(false); | ||
| expect(await inputDatePicker.getProperty("value")).not.toEqual(["2024-01-01", "2024-02-10"]); |
There was a problem hiding this comment.
For clarity, can you assert on the actual values instead? Assertion-wise, this and the assertion on L1237 would pass if they are the same.
anveshmekala
added
skip visual snapshots
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
jcfranco
approved these changes
Apr 27, 2024
jcfranco
changed the title
anveshmekala
deleted the
anveshmekala/9082-fix-input-date-picker-arrow-and-page-keys
branch
benelan
added a commit
that referenced
this pull request
Apr 29, 2024
…ustom-event * origin/main: fix(chip-group): Improve programmatic Chip selection behavior (#9213) test(input-date-picker): add test for no longer closing date-picker when using arrow and page keys. (#9097) build(deps): update actions/setup-node action to v4 (#9143) ci: adds support to test issue template priority status (#9192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9082
Summary
No longer closes
date-pickerininput-date-pickerwhen user interacts with arrowKeys (arrowDown/arrowUp) or pageKeys (pageUp/pageDown).