Skip to content

fix(input-date-picker): hard to reproduce numbering-system caching issue #8518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 2, 2024
Merged

fix(input-date-picker): hard to reproduce numbering-system caching issue #8518

merged 3 commits into from
Jan 2, 2024

Conversation

benelan
Copy link
Member

@benelan benelan commented Dec 28, 2023 •
edited
Loading

Related Issue: #7958

Summary

Resolves an extremely hard to reproduce caching issue that occurs due to Alert's timeouts. The fix is to cache Alert's number formatter per component so it doesn't impact other components.

BEGIN_COMMIT_OVERRIDE
fix(input-date-picker): Resolve a hard to reproduce number formatter caching issue that occurred due to the countdown delay in queued Alerts.
END_COMMIT_OVERRIDE

@benelan benelan requested a review from a team as a code owner December 28, 2023 21:11
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 28, 2023
@benelan benelan changed the title fix(date-picker): hard to reproduce numbering-system caching issue fix(input-date-picker): hard to reproduce numbering-system caching issue Dec 28, 2023
driskull
driskull approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/calcite-components/src/components/alert/alert.tsx
@@ -201,12 +208,6 @@ export class Alert implements OpenCloseComponent, LoadableComponent, T9nComponen
}

render(): VNode {
numberStringFormatter.numberFormatOptions = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but there are other components doing this same thing. Should we update them as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking the same thing. I'll start doing that after I finish some of my other issues for this milestone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this is the only one causing an actual bug that I'm aware of because of the delay. See the repro sample:
https://codepen.io/benesri/pen/YzdodgJ

@benelan benelan added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 2, 2024
@benelan benelan merged commit 5f4fa3e into main Jan 2, 2024
@benelan benelan deleted the benelan/7383-number-formatter-caching branch January 2, 2024 19:23
@github-actions github-actions bot added this to the 2024-01-17 - Jan Main Release milestone Jan 2, 2024
@calcite-admin calcite-admin mentioned this pull request Jan 2, 2024
Merged
benelan added a commit that referenced this pull request Jan 2, 2024
@benelan
fix(input-date-picker): hard to reproduce numbering-system caching is…
79452a8 
…sue (#8518)

**Related Issue:** #7958

## Summary

Resolves an extremely hard to reproduce caching issue that occurs due to
Alert's timeouts. The fix is to cache Alert's number formatter per
component so it doesn't impact other components.
@jcfranco
Copy link
Member

jcfranco commented Jan 3, 2024

@benelan A bit late, but could you revisit the PR title and changelog entry to be brief, yet descriptive (as best as possible)? The start of the description seems like a good starting point:

Resolves an extremely hard to reproduce caching issue that occurs due to Alert's timeouts.

benelan added a commit that referenced this pull request Jan 4, 2024
@benelan
Merge remote-tracking branch 'origin/main' into benelan/required-prop…
08fb2b7 
…-not-internal

* origin/main:
  docs(d, f, g, and h-named components): update api description refs (#8540)
  docs(b and c components): consistent api description refs (#8536)
  ci(update-doc): build design tokens to prevent errors (#8542)
  docs: update component readmes (#8543)
  ci: consistent formatting across packages (#8534)
  refactor(list-item): Remove unnecessary code for rendering open caret (#8537)
  docs(tab-nav, table, tabs, tile-select, tree, value-list): consistent api description refs (#8535)
  chore: release next
  feat(list-item): Add dragSelected property and calciteListItemDragHandleChange event (#8524)
  chore: release next
  fix(input-date-picker): hard to reproduce numbering-system caching issue (#8518)
  feat(handle): add selected property and calciteHandleChange event. (#8484)
  docs(action-bar, action-group, action-pad, alert): consistent api decription refs (#8533)
@geospatialem geospatialem mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@benelan benelan

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-01-17 - Jan Main Release
Development

Successfully merging this pull request may close these issues.
3 participants
@benelan @jcfranco @driskull