Skip to content

fix(input, input-number): correctly sanitize numbers when pasting string with 'e' #7648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/calcite-components/src/utils/number.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,28 @@ describe("parseNumberString", () => {
expect(parseNumberString("")).toBe("");
expect(parseNumberString("only numbers")).toBe("");

// eslint-disable-next-line @cspell/spellchecker
const lettersAndSymbols = "kjas;lkjwo;aij(*&,asd;flkj-";
// eslint-disable-next-line @cspell/spellchecker
const lettersAndSymbolsWithLeadingNegativeSign = "-ASDF(*^LKJihsdf*&^";

expect(parseNumberString(lettersAndSymbols)).toBe("");
expect(parseNumberString(lettersAndSymbolsWithLeadingNegativeSign)).toBe("");
expect(parseNumberString("123test")).toBe("123e");
});

it("returns valid number string for string values that compute to a valid number", () => {
const stringWithLettersAndDigits = "lkj2323lkj";
const frenchNumber = "1 2345,67";
const positiveInteger = "123345345";
// eslint-disable-next-line @cspell/spellchecker
const stringWithLettersDigitsAndSymbols = "123sdfa34345klndfsi8*&(^asdf5345";
const decimal = "123123.234234";
// eslint-disable-next-line @cspell/spellchecker
const stringWithLettersAndDecimal = "12asdfas$%@$3123.23asdf2a4234";
// eslint-disable-next-line @cspell/spellchecker
const stringWithLettersDecimalAndNonLeadingNegativeSign = "12a-sdfas$%@$3123.23asdf2a4234";
// eslint-disable-next-line @cspell/spellchecker
const stringWithLettersDecimalAndLeadingNegativeSign = "-12a-sdfas$%@$3123.23asdf2a4234";

expect(parseNumberString(stringWithLettersAndDigits)).toBe("2323");
Expand Down
2 changes: 1 addition & 1 deletion packages/calcite-components/src/utils/number.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function parseNumberString(numberString?: string): string {
}
return numberKeys.includes(value);
})
.reduce((string, part) => string + part);
.join("");
return isValidNumber(result) ? new BigDecimal(result).toString() : "";
});
}
Expand Down