Skip to content

fix(time-picker): high contrast visibility of outlines in focus and hover states #6129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2022
Merged

fix(time-picker): high contrast visibility of outlines in focus and hover states #6129

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89f2668
time-picker: fix - ensure that outlines are fully visible in high con…
mpriour Dec 20, 2022
07fc7ca
Merge branch 'master' of github.com:Esri/calcite-components
mpriour Dec 20, 2022
0851eca
fix(time-picker): do not overlap focus ring with other elements in hi…
mpriour Dec 20, 2022
2bacb4f
Merge branch 'master' into mpriour/6118-time-picker-high-contrast-vis…
mpriour Dec 20, 2022
74783d2
Merge branch 'master' into mpriour/6118-time-picker-high-contrast-vis…
mpriour Dec 20, 2022
d552c0c
Merge branch 'master' into mpriour/6118-time-picker-high-contrast-vis…
mpriour Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/time-picker/time-picker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
&:focus {
@apply bg-foreground-2
outline-none;
z-index: theme("zIndex.header");
outline-offset: 0;
}
&:active {
@apply bg-foreground-3;
Expand Down Expand Up @@ -62,11 +64,14 @@
font-medium;
&:hover {
box-shadow: inset 0 0 0 2px var(--calcite-ui-foreground-2);
z-index: theme("zIndex.header");
}
&:focus,
&:hover:focus {
@apply outline-none;
box-shadow: inset 0 0 0 2px var(--calcite-ui-brand);
z-index: theme("zIndex.header");
outline-offset: 0;
}
}

Expand Down