fix: fix memory leak caused when disconnecting floating-ui #12107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
benelan
pushed a commit
that referenced
this pull request
May 14, 2025
**Related Issue:** #10648 ## Summary Addresses a memory leak where floating-ui cleanup was not invoked when the component had missing elements. Tear down should always occur if it was previously registered, regardless of component state. Our test environment doesn't cover memory profiling, so no tests were added.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10648
Summary
Addresses a memory leak where floating-ui cleanup was not invoked when the component had missing elements. Tear down should always occur if it was previously registered, regardless of component state.
Our test environment doesn't cover memory profiling, so no tests were added.