Skip to content

fix(shell-panel): handle overflow scrolling #12056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 29, 2025

Conversation

driskull
Copy link
Member

@driskull driskull commented Apr 29, 2025

Related Issue: #12057

Summary

Fixes regression where content isn't overflowing correctly with the newly added internal content-container element.

  • fix regression overflowing content
  • add screenshot test

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 29, 2025
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Apr 29, 2025
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 29, 2025
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 29, 2025
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 29, 2025
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 29, 2025
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 29, 2025
@driskull driskull marked this pull request as ready for review April 29, 2025 21:17
@driskull driskull requested a review from macandcheese April 29, 2025 21:17
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 29, 2025
@driskull driskull added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 29, 2025
@driskull driskull merged commit 0da69e1 into dev Apr 29, 2025
13 checks passed
@driskull driskull deleted the dris0000/shell-panel-overflow-fix branch April 29, 2025 23:56
@github-actions github-actions bot added this to the 2025-04-29 - Apr Milestone milestone Apr 29, 2025
benelan pushed a commit that referenced this pull request May 14, 2025
**Related Issue:** #12057

## Summary

Fixes regression where content isn't overflowing correctly with the
newly added internal `content-container` element.

- fix regression overflowing content
- add screenshot test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants