feat: move Tailwind preset to package #11817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
force-pushed
the
jcfranco/6602-publish-tailwind-config
branch
from
768dfc3 to
f803843
Compare
github-actions
bot
added
the
chore
jcfranco
changed the title
github-actions
bot
added
the
enhancement
jcfranco
added
the
pr ready for visual snapshots
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
|
Self-reminder: follow post-install steps from https://github.com/Esri/calcite-design-system/wiki/monorepo#adding-new-packages. |
jcfranco
requested review from
alisonailea,
benelan and
geospatialem
as code owners
jcfranco
added
pr ready for visual snapshots
|
Happy to hear any thoughts or suggestions on the README and CONTRIBUTING docs. 😄👂 |
jcfranco
added
pr ready for visual snapshots
benelan
reviewed
Apr 8, 2025
benelan
requested changes
Apr 8, 2025
There was a problem hiding this comment.
I think we will get errors publishing this package via the CI because it doesn't exist yet. The first time you publish a scoped package, the command needs --access public.
I think the best option would be publishing 1.0.0 locally so we can specify the access. The changes I mentioned above would no longer be needed too.
jcfranco
added
skip visual snapshots
benelan
approved these changes
Apr 9, 2025
Co-authored-by: Ben Elan <[email protected]>
benelan
added a commit
that referenced
this pull request
May 14, 2025
**Related Issue:** #6602 ## Summary ✨📦✨ --------- Co-authored-by: Ben Elan <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6602
Summary
✨📦✨