feat: add check #11799

arowles · 2025-03-24T19:52:25Z

Related Issue: #

Summary

added

check-16
check-24
check-32

BEGIN_COMMIT_OVERRIDE
feat: update check
END_COMMIT_OVERRIDE

This reverts commit a213942.

arowles · 2025-03-24T19:59:28Z

@benelan and @jcfranco
The fantasticonrc file did not show that it was updated even after re-launching the commit multiple times, but in the package folder on my branch shows that it was last updated today which would be correct.

Should I still merge this branch even though the update is not listed?

nicklu10

thanks for uploading them!

…igration-ssr * origin/dev: build(deps): update nx monorepo to v20.6.2 (#11797) build(deps): update eslint (#11796) build(deps): update dependency @prettier/sync to v0.5.3 (#11795) docs: update list of contributors (#11803) build(deps): update arcgis to ^4.32.12 (#11794) feat: add check (#11799) chore: release next feat(accordion): add new component tokens and deprecate old tokens (#11390)

benelan · 2025-03-25T04:08:04Z

@arowles a check icon already existed, was your intention to replace it? There are duplicate entries in keywords.json:

calcite-design-system/packages/calcite-ui-icons/docs/keywords.json

Lines 465 to 469 in 5bec083

    
           "check": { 
        
             "alias": ["1.5.0", "symbols", "mark", "selected"], 
        
             "category": "Symbols", 
        
             "release": "1.5" 
        
           },

calcite-design-system/packages/calcite-ui-icons/docs/keywords.json

Lines 9521 to 9525 in 5bec083

    
           "check": { 
        
             "alias": ["4.1.0", "symbols", "mark", "selected", "completed"], 
        
             "category": "Symbols", 
        
             "release": "4.1.0" 
        
           }

I also noticed there are two entries for effects:

calcite-design-system/packages/calcite-ui-icons/docs/keywords.json

Lines 4298 to 4302 in 5bec083

    
           "effects": { 
        
             "alias": ["3.16.3", "objects", "flash", "sparkles", "filters", "stars", "constellations", "flashy", "shiny"], 
        
             "category": "Objects", 
        
             "release": "3.16.3" 
        
           },

calcite-design-system/packages/calcite-ui-icons/docs/keywords.json

Lines 8452 to 8456 in 5bec083

    
           "effects": { 
        
             "alias": ["3.27.4", "objects", "ai", "sparkle", "system", "machine learning"], 
        
             "category": "Objects", 
        
             "release": "3.27.1" 
        
           },

Can you create a new pull request removing either of the duplicates?

nicklu10 · 2025-03-25T15:39:19Z

@benelan yes this was meant to update and replace the existing Check icon. thanks!

jcfranco · 2025-03-25T16:24:34Z

Correct me if I'm wrong, but I think @benelan's earlier comment was suggesting to revisit the replaced entries. Since replaced properties get overridden (and inaccessible) in the keywords object, there's no need to keep it (see example). If keywords.json is more for historical context, maybe there's a different format or structure that could be used?

arowles · 2025-03-25T17:13:37Z

@arowles a check icon already existed, was your intention to replace it? There are duplicate entries in keywords.json:

calcite-design-system/packages/calcite-ui-icons/docs/keywords.json

Lines 465 to 469 in 5bec083

"check": {

"alias": ["1.5.0", "symbols", "mark", "selected"],

"category": "Symbols",

"release": "1.5"

},

calcite-design-system/packages/calcite-ui-icons/docs/keywords.json

Lines 9521 to 9525 in 5bec083

"check": {

"alias": ["4.1.0", "symbols", "mark", "selected", "completed"],

"category": "Symbols",

"release": "4.1.0"

}

I also noticed there are two entries for effects:

calcite-design-system/packages/calcite-ui-icons/docs/keywords.json

Lines 4298 to 4302 in 5bec083

"effects": {

"alias": ["3.16.3", "objects", "flash", "sparkles", "filters", "stars", "constellations", "flashy", "shiny"],

"category": "Objects",

"release": "3.16.3"

},

calcite-design-system/packages/calcite-ui-icons/docs/keywords.json

Lines 8452 to 8456 in 5bec083

"effects": {

"alias": ["3.27.4", "objects", "ai", "sparkle", "system", "machine learning"],

"category": "Objects",

"release": "3.27.1"

},

Can you create a new pull request removing either of the duplicates?

Yes! I am working on it now

…low-item-like-type * origin/dev: revert(fab): add component tokens (#11805) docs(combobox, combobox-item): update token descriptions (#11806) feat(fab): add component tokens (#11723) chore: release next feat(combobox-item): update idle icons (#11801) build(deps): update nx monorepo to v20.6.2 (#11797) build(deps): update eslint (#11796) build(deps): update dependency @prettier/sync to v0.5.3 (#11795) docs: update list of contributors (#11803) build(deps): update arcgis to ^4.32.12 (#11794) feat: add check (#11799) chore: release next feat(accordion): add new component tokens and deprecate old tokens (#11390) build(deps): update storybook monorepo to v8.6.7 (#11783) build: update browserslist db (#11792)

**Related Issue:** # ## Summary **added** check-16 check-24 check-32 ![image](https://github.com/user-attachments/assets/b890cb26-4ee0-4663-877d-3a414c8b4edf) --------- Co-authored-by: Ashley Rowles <[email protected]>

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-design-tokens: 3.0.1</summary> ## [3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) ### Bug Fixes * Allow global focus color token to inherit fallback value ([#11711](#11711)) ([a732c8d](a732c8d)) </details> <details><summary>@esri/calcite-ui-icons: 4.1.0</summary> ## [4.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) ### Features * Add browser join and browser plus ([#11779](#11779)) ([8f69b2d](8f69b2d)) * Update check ([#11799](#11799)) ([5058939](5058939)) * Add language-2 ([#11739](#11739)) ([989df67](989df67)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 2.0.1</summary> ## [2.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) **Note:** Version bump only for package @esri/eslint-plugin-calcite-components </details> <details><summary>@esri/calcite-components: 3.1.0</summary> ## [3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) ### Features * **accordion:** Add new component tokens and deprecate old tokens ([#11390](#11390)) ([fdf3e61](fdf3e61)) * **action:** Enhance component's interactivity states ([#11478](#11478)) ([aad98df](aad98df)) * **block, block-section:** Add `expanded` property and deprecate `open` property ([#11582](#11582)) ([999f532](999f532)) * **button:** Enhance component's interactivity states ([#11590](#11590)) ([23a62ca](23a62ca)) * **chip:** Deprecate `pressed` in favor of `press` ([#11389](#11389)) ([c905f9f](c905f9f)) * **chip:** Enhance component's interactivity states ([#11538](#11538)) ([8db5697](8db5697)) * **combobox-item:** Add component tokens ([#11645](#11645)) ([9cbd155](9cbd155)) * **combobox-item:** Update idle icons ([#11801](#11801)) ([034f430](034f430)) * **combobox-item:** Update interactive state ([#11647](#11647)) ([19d7c43](19d7c43)) * **combobox-item:** Update selection icons ([#11726](#11726)) ([723fd22](723fd22)) * **combobox, combobox-item-group:** Add component tokens ([#11623](#11623)) ([8215314](8215314)) * **dropdown, dropdown-item, dropdown-group:** Add component tokens ([#11465](#11465)) ([85f9378](85f9378)) * **dropdown:** Add `offsetDistance` and `offsetSkidding` properties ([#11614](#11614)) ([3381040](3381040)) * **fab:** Add component tokens ([#11723](#11723)) ([d436514](d436514)) * **flow-item:** Expose `FlowItemLike` type ([#11791](#11791)) ([28c7522](28c7522)) * **list-item, list:** Add `expanded` property and deprecate `open` property ([#11003](#11003)) ([c80c44c](c80c44c)) * **rating:** Enhance component's interactivity states ([#11469](#11469)) ([11d83f6](11d83f6)) * **segmented-control-item:** Enhance component's interactivity states ([#11477](#11477)) ([f025330](f025330)) * **split-button:** Make downloadable and linkable ([#11520](#11520)) ([fb3e1dc](fb3e1dc)) * **tab-title:** Enhance component's interactivity states ([#11493](#11493)) ([88a5260](88a5260)) ### Bug Fixes * **card-group:** Restore default gap spacing ([#11638](#11638)) ([a554598](a554598)) * **dropdown-group:** Fix error caused by early removal ([#11612](#11612)) ([2dcef25](2dcef25)) * **panel:** Apply custom styles correctly to header actions ([#11495](#11495)) ([5e84892](5e84892)) * Set floating-ui elements max size set to the view ([#11577](#11577)) ([b3ffd7f](b3ffd7f)) * **tabs:** Redisplay close button when more than one tab is closable ([#11492](#11492)) ([ae8064e](ae8064e)) * **text-area:** Fix error caused by internal measuring on disconnect ([#11751](#11751)) ([810f79e](810f79e)) * **tooltip:** Close tooltip when hovering out of an iframe ([#11600](#11600)) ([93a5692](93a5692)) * **tooltip:** Do not open after the pointer has moved off of the reference element ([#11599](#11599)) ([33cadc8](33cadc8)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 4.1.0-next.3 to 4.1.0 * devDependencies * @esri/calcite-design-tokens bumped from 3.0.1-next.4 to 3.0.1 * @esri/eslint-plugin-calcite-components bumped from 2.0.1-next.2 to 2.0.1 </details> <details><summary>@esri/calcite-components-react: 3.1.0</summary> ## [3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 3.1.0-next.31 to 3.1.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <[email protected]>

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-design-tokens: 3.0.1</summary> [3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) * Allow global focus color token to inherit fallback value ([#11711](#11711)) ([a732c8d](a732c8d)) </details> <details><summary>@esri/calcite-ui-icons: 4.1.0</summary> [4.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) * Add browser join and browser plus ([#11779](#11779)) ([8f69b2d](8f69b2d)) * Update check ([#11799](#11799)) ([5058939](5058939)) * Add language-2 ([#11739](#11739)) ([989df67](989df67)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 2.0.1</summary> [2.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) **Note:** Version bump only for package @esri/eslint-plugin-calcite-components </details> <details><summary>@esri/calcite-components: 3.1.0</summary> [3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) * **accordion:** Add new component tokens and deprecate old tokens ([#11390](#11390)) ([fdf3e61](fdf3e61)) * **action:** Enhance component's interactivity states ([#11478](#11478)) ([aad98df](aad98df)) * **block, block-section:** Add `expanded` property and deprecate `open` property ([#11582](#11582)) ([999f532](999f532)) * **button:** Enhance component's interactivity states ([#11590](#11590)) ([23a62ca](23a62ca)) * **chip:** Deprecate `pressed` in favor of `press` ([#11389](#11389)) ([c905f9f](c905f9f)) * **chip:** Enhance component's interactivity states ([#11538](#11538)) ([8db5697](8db5697)) * **combobox-item:** Add component tokens ([#11645](#11645)) ([9cbd155](9cbd155)) * **combobox-item:** Update idle icons ([#11801](#11801)) ([034f430](034f430)) * **combobox-item:** Update interactive state ([#11647](#11647)) ([19d7c43](19d7c43)) * **combobox-item:** Update selection icons ([#11726](#11726)) ([723fd22](723fd22)) * **combobox, combobox-item-group:** Add component tokens ([#11623](#11623)) ([8215314](8215314)) * **dropdown, dropdown-item, dropdown-group:** Add component tokens ([#11465](#11465)) ([85f9378](85f9378)) * **dropdown:** Add `offsetDistance` and `offsetSkidding` properties ([#11614](#11614)) ([3381040](3381040)) * **fab:** Add component tokens ([#11723](#11723)) ([d436514](d436514)) * **flow-item:** Expose `FlowItemLike` type ([#11791](#11791)) ([28c7522](28c7522)) * **list-item, list:** Add `expanded` property and deprecate `open` property ([#11003](#11003)) ([c80c44c](c80c44c)) * **rating:** Enhance component's interactivity states ([#11469](#11469)) ([11d83f6](11d83f6)) * **segmented-control-item:** Enhance component's interactivity states ([#11477](#11477)) ([f025330](f025330)) * **split-button:** Make downloadable and linkable ([#11520](#11520)) ([fb3e1dc](fb3e1dc)) * **tab-title:** Enhance component's interactivity states ([#11493](#11493)) ([88a5260](88a5260)) * **card-group:** Restore default gap spacing ([#11638](#11638)) ([a554598](a554598)) * **dropdown-group:** Fix error caused by early removal ([#11612](#11612)) ([2dcef25](2dcef25)) * **panel:** Apply custom styles correctly to header actions ([#11495](#11495)) ([5e84892](5e84892)) * Set floating-ui elements max size set to the view ([#11577](#11577)) ([b3ffd7f](b3ffd7f)) * **tabs:** Redisplay close button when more than one tab is closable ([#11492](#11492)) ([ae8064e](ae8064e)) * **text-area:** Fix error caused by internal measuring on disconnect ([#11751](#11751)) ([810f79e](810f79e)) * **tooltip:** Close tooltip when hovering out of an iframe ([#11600](#11600)) ([93a5692](93a5692)) * **tooltip:** Do not open after the pointer has moved off of the reference element ([#11599](#11599)) ([33cadc8](33cadc8)) * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 4.1.0-next.3 to 4.1.0 * devDependencies * @esri/calcite-design-tokens bumped from 3.0.1-next.4 to 3.0.1 * @esri/eslint-plugin-calcite-components bumped from 2.0.1-next.2 to 2.0.1 </details> <details><summary>@esri/calcite-components-react: 3.1.0</summary> [3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 3.1.0-next.31 to 3.1.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <[email protected]>

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-design-tokens: 3.0.1</summary> [3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) * Allow global focus color token to inherit fallback value ([#11711](#11711)) ([a732c8d](a732c8d)) </details> <details><summary>@esri/calcite-ui-icons: 4.1.0</summary> [4.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) * Add browser join and browser plus ([#11779](#11779)) ([8f69b2d](8f69b2d)) * Update check ([#11799](#11799)) ([5058939](5058939)) * Add language-2 ([#11739](#11739)) ([989df67](989df67)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 2.0.1</summary> [2.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) **Note:** Version bump only for package @esri/eslint-plugin-calcite-components </details> <details><summary>@esri/calcite-components: 3.1.0</summary> [3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) * **accordion:** Add new component tokens and deprecate old tokens ([#11390](#11390)) ([fdf3e61](fdf3e61)) * **action:** Enhance component's interactivity states ([#11478](#11478)) ([aad98df](aad98df)) * **block, block-section:** Add `expanded` property and deprecate `open` property ([#11582](#11582)) ([999f532](999f532)) * **button:** Enhance component's interactivity states ([#11590](#11590)) ([23a62ca](23a62ca)) * **chip:** Deprecate `pressed` in favor of `press` ([#11389](#11389)) ([c905f9f](c905f9f)) * **chip:** Enhance component's interactivity states ([#11538](#11538)) ([8db5697](8db5697)) * **combobox-item:** Add component tokens ([#11645](#11645)) ([9cbd155](9cbd155)) * **combobox-item:** Update idle icons ([#11801](#11801)) ([034f430](034f430)) * **combobox-item:** Update interactive state ([#11647](#11647)) ([19d7c43](19d7c43)) * **combobox-item:** Update selection icons ([#11726](#11726)) ([723fd22](723fd22)) * **combobox, combobox-item-group:** Add component tokens ([#11623](#11623)) ([8215314](8215314)) * **dropdown, dropdown-item, dropdown-group:** Add component tokens ([#11465](#11465)) ([85f9378](85f9378)) * **dropdown:** Add `offsetDistance` and `offsetSkidding` properties ([#11614](#11614)) ([3381040](3381040)) * **fab:** Add component tokens ([#11723](#11723)) ([d436514](d436514)) * **flow-item:** Expose `FlowItemLike` type ([#11791](#11791)) ([28c7522](28c7522)) * **list-item, list:** Add `expanded` property and deprecate `open` property ([#11003](#11003)) ([c80c44c](c80c44c)) * **rating:** Enhance component's interactivity states ([#11469](#11469)) ([11d83f6](11d83f6)) * **segmented-control-item:** Enhance component's interactivity states ([#11477](#11477)) ([f025330](f025330)) * **split-button:** Make downloadable and linkable ([#11520](#11520)) ([fb3e1dc](fb3e1dc)) * **tab-title:** Enhance component's interactivity states ([#11493](#11493)) ([88a5260](88a5260)) * **card-group:** Restore default gap spacing ([#11638](#11638)) ([a554598](a554598)) * **dropdown-group:** Fix error caused by early removal ([#11612](#11612)) ([2dcef25](2dcef25)) * **panel:** Apply custom styles correctly to header actions ([#11495](#11495)) ([5e84892](5e84892)) * Set floating-ui elements max size set to the view ([#11577](#11577)) ([b3ffd7f](b3ffd7f)) * **tabs:** Redisplay close button when more than one tab is closable ([#11492](#11492)) ([ae8064e](ae8064e)) * **text-area:** Fix error caused by internal measuring on disconnect ([#11751](#11751)) ([810f79e](810f79e)) * **tooltip:** Close tooltip when hovering out of an iframe ([#11600](#11600)) ([93a5692](93a5692)) * **tooltip:** Do not open after the pointer has moved off of the reference element ([#11599](#11599)) ([33cadc8](33cadc8)) * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 4.1.0-next.3 to 4.1.0 * devDependencies * @esri/calcite-design-tokens bumped from 3.0.1-next.4 to 3.0.1 * @esri/eslint-plugin-calcite-components bumped from 2.0.1-next.2 to 2.0.1 </details> <details><summary>@esri/calcite-components-react: 3.1.0</summary> [3.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-26) * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 3.1.0-next.31 to 3.1.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <[email protected]> Co-authored-by: Calcite Admin <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Ashley Rowles added 3 commits March 21, 2025 12:07

feat: replaced icons

76e61cf

feat: added tags

262e9f6

launched ref page

a213942

arowles requested review from benelan and jcfranco as code owners March 24, 2025 19:52

arowles requested a review from nicklu10 March 24, 2025 19:52

github-actions bot assigned arowles Mar 24, 2025

arowles changed the title ~~add check~~ feat: add check Mar 24, 2025

calcite-admin added the skip visual snapshots Pull requests that do not need visual regression testing. label Mar 24, 2025

Revert "launched ref page"

eee3acf

This reverts commit a213942.

github-actions bot added the enhancement Issues tied to a new feature or request. label Mar 24, 2025

feat: re-launched ref page

9c9df28

nicklu10 approved these changes Mar 24, 2025

View reviewed changes

arowles merged commit b61b2a1 into dev Mar 24, 2025
10 checks passed

arowles deleted the arowles/add-pin-icons branch March 24, 2025 22:28

github-actions bot added this to the 2025-03-25 - 3.1.0 Mar Release milestone Mar 24, 2025

calcite-admin mentioned this pull request Mar 26, 2025

chore: release main #11809

Merged

benelan mentioned this pull request Mar 26, 2025

chore: cherry pick release commit from main #11813

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add check #11799

feat: add check #11799

Uh oh!

arowles commented Mar 24, 2025 •

edited by benelan

Loading

Uh oh!

arowles commented Mar 24, 2025

Uh oh!

nicklu10 left a comment

Uh oh!

Uh oh!

benelan commented Mar 25, 2025

Uh oh!

nicklu10 commented Mar 25, 2025

Uh oh!

jcfranco commented Mar 25, 2025

Uh oh!

arowles commented Mar 25, 2025

Uh oh!

Uh oh!

feat: add check #11799

feat: add check #11799

Uh oh!

Conversation

arowles commented Mar 24, 2025 • edited by benelan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

arowles commented Mar 24, 2025

Uh oh!

nicklu10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

benelan commented Mar 25, 2025

Uh oh!

nicklu10 commented Mar 25, 2025

Uh oh!

jcfranco commented Mar 25, 2025

Uh oh!

arowles commented Mar 25, 2025

Uh oh!

Uh oh!

arowles commented Mar 24, 2025 •

edited by benelan

Loading