feat(avatar): ensure different backgrounds are generated for similar usernames, full names and user IDs #9277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usernames, full names and user IDs
jcfranco
added
the
pr ready for visual snapshots
paulcpederson
approved these changes
May 7, 2024
|
This should be fine as it's still deterministic. Little code golf comment, but looks great 👍🏻 |
jcfranco
added
skip visual snapshots
jcfranco
deleted the
jcfranco/6497-improve-avatar-randomized-bg-color-on-similar-input
branch
Merged
geospatialem
modified the milestones:
2024-05-14 - May maintenance release,
2024-05-28 - May Main Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6497
Summary
This updates
avatarto create unique background colors for similar name strings. This is done by mixing the input string in a deterministic way before building the hash and mapping the color.