fix(input-time-picker): invert text color on Windows when each masked input is focused #12130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… input is focused
github-actions
bot
added
the
bug
driskull
requested changes
May 12, 2025
packages/calcite-components/src/components/input-time-picker/input-time-picker.tsx
Outdated
Show resolved
Hide resolved
eriklharper
added
the
pr ready for visual snapshots
geospatialem
approved these changes
May 13, 2025
eriklharper
deleted the
eriklharper/12122-windows-input-time-picker-color-contrast
branch
benelan
pushed a commit
that referenced
this pull request
May 14, 2025
… input is focused (#12130) **Related Issue:** #12122 ## Summary This inverts the text color of each focused input in `calcite-input-time-picker` for Windows browsers whose system highlight color doesn't provide sufficient contrast by setting the text color to use the system `HighlightText` keyword. For more information: https://css-tricks.com/system-things/ Tested on Chrome, Firefox and Edge on Windows 10 Enterprise build 19045.5737. Chrome Version 136.0.7103.93 (Official Build) (64-bit) <img width="562" alt="image" src="https://github.com/user-attachments/assets/e883157e-6f93-4d0d-8f8b-63dc6e466e90" /> Firefox Version 138.0.1 (64-bit)  Edge Version 136.0.3240.64 (Official build) (64-bit) 
Merged
benelan
added a commit
that referenced
this pull request
May 15, 2025
* origin/dev: (277 commits) docs(tokens): consistency pass for new component descriptions (#12148) build(preset): use valid TS module resolution (#12151) docs: update list of contributors (#12134) chore: drop obsolete transforms (#12136) chore: release main (#11890) (#12147) build(deps): bump @arcgis/lumina, typescript, vite, vitest (#12137) chore(preset): fix JSON import in build config (#12142) docs(panel, action): update `text-color-pressed` token descriptions (#12140) chore: release next fix(input-time-picker): invert text color on Windows when each masked input is focused (#12130) chore: release next refactor(sematic-tokens): update `--calcite-corner-radius-default` to reference correct token (#12131) feat(semantic-tokens): add `--calcite-color-text-highlight` tokens (#12068) chore: release next feat(combobox): add `selectAll` toggle property (#11721) chore: release next fix(sort-handle): allow move and reorder events to be cancelled (#12095) chore: release next feat: added spike data, heart chart, and progress bar icons (#12127) feat(text-area): Add design tokens for corner radius, shadow, footer background color (#12124) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #12122
Summary
This inverts the text color of each focused input in
calcite-input-time-pickerfor Windows browsers whose system highlight color doesn't provide sufficient contrast by setting the text color to use the systemHighlightTextkeyword.For more information: https://css-tricks.com/system-things/
Tested on Chrome, Firefox and Edge on Windows 10 Enterprise build 19045.5737.
Chrome Version 136.0.7103.93 (Official Build) (64-bit)
Firefox Version 138.0.1 (64-bit)
Edge Version 136.0.3240.64 (Official build) (64-bit)
