feat(filter): add component tokens #11885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
added
the
pr ready for visual snapshots
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
github-actions
bot
removed
the
Stale
|
Ping. still need a review on this one. |
| /** | ||
| * CSS Custom Properties | ||
| * | ||
| * @prop --calcite-filter-content-space: Specifies the padding of the component's content. |
There was a problem hiding this comment.
Is this in practice the space around the input? Might be a little confusing here as it kind of insinuates there is a default slot for Filter. Nothing actionable here I don't think - are we still planning on deprecating the Filter component?
There was a problem hiding this comment.
I commented on the issue as well.
macandcheese
approved these changes
Apr 29, 2025
driskull
added
pr ready for visual snapshots
benelan
pushed a commit
that referenced
this pull request
May 14, 2025
**Related Issue:** #7180 ## Summary Adds the following tokens for `filter` component. - --calcite-filter-content-space: Specifies the padding of the component's content. - --calcite-filter-input-background-color: Specifies the input's background color. - --calcite-filter-input-border-color: Specifies the input's border color. - --calcite-filter-input-corner-radius: Specifies the input's corner radius. - --calcite-filter-input-shadow: Specifies the shadow around the input. - --calcite-filter-input-icon-color: Specifies the input's icon color. - --calcite-filter-input-text-color: Specifies the input's text color. - --calcite-filter-input-placeholder-text-color: Specifies the input's placeholder text color. - --calcite-filter-input-actions-background-color: Specifies the background color of the input's `clearable` and `number-button-type` elements. - --calcite-filter-input-actions-background-color-hover: Specifies the background color of the input's `clearable` and `number-button-type` elements when hovered. - --calcite-filter-input-actions-background-color-press: Specifies the background color of the input's `clearable` and `number-button-type` elements when pressed. - --calcite-filter-input-actions-icon-color: Specifies the icon color of the input's `clearable` and `number-button-type` elements. - --calcite-filter-input-actions-icon-color-hover: Specifies the icon color of the input's `clearable` and `number-button-type` elements when hovered. - --calcite-filter-input-actions-icon-color-press: Specifies the icon color of the input's `clearable` and `number-button-type` elements when pressed. /nts when pressed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds the following tokens for
filtercomponent.clearableandnumber-button-typeelements.clearableandnumber-button-typeelements when hovered.clearableandnumber-button-typeelements when pressed.clearableandnumber-button-typeelements.clearableandnumber-button-typeelements when hovered.clearableandnumber-button-typeelements when pressed./nts when pressed.