Skip to content

Commit e7024e4

Browse files
chore: checking method inside readWebsocketMessage
1 parent adad86e commit e7024e4

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

dot/rpc/subscription/websocket.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ type httpclient interface {
3232
Do(*http.Request) (*http.Response, error)
3333
}
3434

35-
var errCannotReadFromWebsocket = errors.New("cannot read message from websocket")
35+
var (
36+
errCannotReadFromWebsocket = errors.New("cannot read message from websocket")
37+
errEmptyMethod = errors.New("empty method")
38+
)
39+
3640
var logger = log.NewFromGlobal(log.AddContext("pkg", "rpc/subscription"))
3741

3842
// WSConn struct to hold WebSocket Connection references
@@ -63,6 +67,10 @@ func (c *WSConn) readWebsocketMessage() (rawBytes []byte, wsMessage *websocketMe
6367
return nil, nil, err
6468
}
6569

70+
if wsMessage.Method == "" {
71+
return nil, nil, errEmptyMethod
72+
}
73+
6674
return rawBytes, wsMessage, nil
6775
}
6876

@@ -81,12 +89,6 @@ func (c *WSConn) HandleConn() {
8189
}
8290

8391
logger.Tracef("websocket message received: %s", string(rawBytes))
84-
85-
if wsMessage.Method == "" {
86-
c.safeSendError(0, big.NewInt(InvalidRequestCode), InvalidRequestMessage)
87-
continue
88-
}
89-
9092
logger.Debugf("ws method %s called with params %v", wsMessage.Method, wsMessage.Params)
9193

9294
if !strings.Contains(wsMessage.Method, "_unsubscribe") && !strings.Contains(wsMessage.Method, "_unwatch") {

0 commit comments

Comments
 (0)