chore: use value instead of pointer

Author: EclesioMeloJunior

dot/network/notifications_test.go

@@ -198,9 +198,9 @@ func TestCreateNotificationsMessageHandler_BlockAnnounceHandshake(t *testing.T)
 	err = handler(stream, testHandshake)
 	require.ErrorIs(t, err, errCannotValidateHandshake)
 
-	expectedError := fmt.Errorf("handling handshake: %w from peer %s using protocol %s: %s",
-		errCannotValidateHandshake, testPeerID, info.protocolID, errors.New("genesis hash mismatch"))
-	require.EqualError(t, err, expectedError.Error())
+	expectedErrorMessage := fmt.Sprintf("handling handshake: %s from peer %s using protocol %s: genesis hash mismatch",
+		errCannotValidateHandshake, testPeerID, info.protocolID)
+	require.EqualError(t, err, expectedErrorMessage)
 
 	data := info.peersData.getInboundHandshakeData(testPeerID)
 	require.NotNil(t, data)

dot/sync/chain_processor.go

@@ -57,7 +57,7 @@ type chainProcessorConfig struct {
 	telemetry          telemetry.Client
 }
 
-func newChainProcessor(cfg *chainProcessorConfig) *chainProcessor {
+func newChainProcessor(cfg chainProcessorConfig) *chainProcessor {
 	ctx, cancel := context.WithCancel(context.Background())
 
 	return &chainProcessor{

dot/sync/chain_processor_test.go

@@ -1148,7 +1148,7 @@ func Test_newChainProcessor(t *testing.T) {
 		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
-			cpCfg := &chainProcessorConfig{
+			cpCfg := chainProcessorConfig{
 				readyBlocks:        tt.args.readyBlocks,
 				pendingBlocks:      tt.args.pendingBlocks,
 				blockState:         tt.args.blockState,

dot/sync/chain_sync.go

@@ -176,7 +176,7 @@ type chainSyncConfig struct {
 	slotDuration       time.Duration
 }
 
-func newChainSync(cfg *chainSyncConfig) *chainSync {
+func newChainSync(cfg chainSyncConfig) *chainSync {
 	ctx, cancel := context.WithCancel(context.Background())
 	const syncSamplesToKeep = 30
 	const logSyncPeriod = 5 * time.Second

dot/sync/chain_sync_test.go

@@ -865,7 +865,7 @@ func TestChainSync_validateResponse(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)
 
-			cfg := &chainSyncConfig{
+			cfg := chainSyncConfig{
 				bs:            tt.blockStateBuilder(ctrl),
 				pendingBlocks: newDisjointBlockSet(pendingBlocksLimit),
 				readyBlocks:   newBlockQueue(maxResponseSize),
@@ -1601,7 +1601,7 @@ func newTestChainSyncWithReadyBlocks(ctrl *gomock.Controller, readyBlocks *block
 	mockBlockState := NewMockBlockState(ctrl)
 	mockBlockState.EXPECT().GetFinalisedNotifierChannel().Return(make(chan *types.FinalisationInfo))
 
-	cfg := &chainSyncConfig{
+	cfg := chainSyncConfig{
 		bs:            mockBlockState,
 		readyBlocks:   readyBlocks,
 		pendingBlocks: newDisjointBlockSet(pendingBlocksLimit),

dot/sync/syncer.go

@@ -46,7 +46,7 @@ func NewService(cfg *Config) (*Service, error) {
 	readyBlocks := newBlockQueue(maxResponseSize * 30)
 	pendingBlocks := newDisjointBlockSet(pendingBlocksLimit)
 
-	csCfg := &chainSyncConfig{
+	csCfg := chainSyncConfig{
 		bs:            cfg.BlockState,
 		net:           cfg.Network,
 		readyBlocks:   readyBlocks,
@@ -57,7 +57,7 @@ func NewService(cfg *Config) (*Service, error) {
 	}
 	chainSync := newChainSync(csCfg)
 
-	cpCfg := &chainProcessorConfig{
+	cpCfg := chainProcessorConfig{
 		readyBlocks:        readyBlocks,
 		pendingBlocks:      pendingBlocks,
 		syncer:             chainSync,