Skip to content

Commit 26f17e2

Browse files
authored
feat: disable factory bot association cop by default (#49)
**Summary of changes**: Per a conversation in Slack we don't seem to have strong opinions about this, so disabling this cop here for all our projects using Betterlint.
1 parent 048be08 commit 26f17e2

File tree

3 files changed

+16
-13
lines changed

3 files changed

+16
-13
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: .
33
specs:
4-
betterlint (1.12.0)
4+
betterlint (1.13.0)
55
rubocop (~> 1.62.0)
66
rubocop-graphql (~> 1.5.0)
77
rubocop-performance (~> 1.21.0)

betterlint.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
55

66
Gem::Specification.new do |s|
77
s.name = "betterlint"
8-
s.version = "1.12.0"
8+
s.version = "1.13.0"
99
s.authors = ["Development"]
1010
s.email = ["[email protected]"]
1111
s.summary = "Betterment rubocop configuration"

config/default.yml

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,18 @@ Betterment/NonStandardActions:
5656
- update
5757
StyleGuide: '#bettermentnonstandardactions'
5858

59+
Betterment/RedirectStatus:
60+
SafeAutoCorrect: false
61+
Description: Detect missing status codes when redirecting POST, PUT, PATCH, or DELETE responses
62+
Include:
63+
- app/controllers/**/*.rb
64+
65+
Betterment/RenderStatus:
66+
SafeAutoCorrect: false
67+
Description: Detect missing status codes when rendering POST, PUT, PATCH, or DELETE responses
68+
Include:
69+
- app/controllers/**/*.rb
70+
5971
Betterment/ServerErrorAssertion:
6072
Description: Detects assertions on 5XX HTTP statuses.
6173
Include:
@@ -77,17 +89,8 @@ Betterment/UnsafeJob:
7789
Betterment/UnscopedFind:
7890
StyleGuide: '#bettermentunscopedfind'
7991

80-
Betterment/RedirectStatus:
81-
SafeAutoCorrect: false
82-
Description: Detect missing status codes when redirecting POST, PUT, PATCH, or DELETE responses
83-
Include:
84-
- app/controllers/**/*.rb
85-
86-
Betterment/RenderStatus:
87-
SafeAutoCorrect: false
88-
Description: Detect missing status codes when rendering POST, PUT, PATCH, or DELETE responses
89-
Include:
90-
- app/controllers/**/*.rb
92+
FactoryBot/AssociationStyle:
93+
Enabled: false
9194

9295
FactoryBot/ConsistentParenthesesStyle:
9396
Enabled: false

0 commit comments

Comments
 (0)