Fix edge cases in status code autocorrection (#41)

* Handle `render` or `redirect_to` with parentheses
* Handle `render` or `redirect_to` with no arguments

Author: rzane

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    betterlint (1.10.0)
+    betterlint (1.10.1)
       rubocop (~> 1.62.0)
       rubocop-performance (~> 1.21.0)
       rubocop-rails (~> 2.24.0)

betterlint.gemspec

@@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |s|
   s.name = "betterlint"
-  s.version = "1.10.0"
+  s.version = "1.10.1"
   s.authors = ["Development"]
   s.email = ["[email protected]"]
   s.summary = "Betterment rubocop configuration"

lib/rubocop/cop/betterment/redirect_status.rb

@@ -17,11 +17,7 @@ class RedirectStatus < Base
         MSG
 
         def on_def(node)
-          each_offense(node, :redirect_to) do |responder|
-            add_offense(responder) do |corrector|
-              corrector.insert_after(responder, ", status: :see_other")
-            end
-          end
+          each_offense(node, :redirect_to) { :see_other }
         end
       end
     end

lib/rubocop/cop/betterment/render_status.rb

@@ -18,9 +18,7 @@ class RenderStatus < Base
 
         def on_def(node)
           each_offense(node, :render) do |responder|
-            add_offense(responder) do |corrector|
-              corrector.insert_after(responder, ", status: #{infer_status(responder).inspect}")
-            end
+            infer_status(responder)
           end
         end
 

lib/rubocop/cop/betterment/utils/response_status.rb

@@ -11,15 +11,28 @@ module ResponseStatus
 
           private
 
-          def each_offense(node, responder_name, &block)
-            if UNSAFE_ACTIONS.include?(node.method_name)
-              on_missing_status(node, responder_name, &block)
+          def each_offense(node, responder_name)
+            return unless UNSAFE_ACTIONS.include?(node.method_name)
+
+            on_missing_status(node, responder_name) do |responder|
+              add_offense(responder) do |corrector|
+                status = yield(responder)
+
+                if responder.arguments?
+                  corrector.insert_after(responder.last_argument, ", status: #{status.inspect}")
+                else
+                  corrector.replace(responder, "#{responder_name} status: #{status.inspect}")
+                end
+              end
             end
           end
 
           # @!method on_missing_status(node)
           def_node_search :on_missing_status, <<~PATTERN
-            (send nil? %1 ... !(hash <(pair (sym :status) _) ...>))
+            {
+              (send nil? %1)
+              (send nil? %1 ... !(hash <(pair (sym :status) _) ...>))
+            }
           PATTERN
         end
       end

spec/rubocop/cop/betterment/redirect_status_spec.rb

@@ -8,21 +8,27 @@
       def create
         redirect_to '/'
         ^^^^^^^^^^^^^^^ Did you forget to specify an HTTP status code? [...]
+        redirect_to('/')
+        ^^^^^^^^^^^^^^^^ Did you forget to specify an HTTP status code? [...]
       end
 
       def update
         redirect_to '/'
         ^^^^^^^^^^^^^^^ Did you forget to specify an HTTP status code? [...]
+        redirect_to
+        ^^^^^^^^^^^ Did you forget to specify an HTTP status code? [...]
       end
     RUBY
 
     expect_correction(<<~RUBY)
       def create
         redirect_to '/', status: :see_other
+        redirect_to('/', status: :see_other)
       end
 
       def update
         redirect_to '/', status: :see_other
+        redirect_to status: :see_other
       end
     RUBY
   end
@@ -48,6 +54,7 @@ def edit
       def create
         redirect_to '/', status: :found
         redirect_to '/', status: :see_other
+        redirect_to status: :found
       end
     RUBY
   end

spec/rubocop/cop/betterment/render_status_spec.rb

@@ -16,6 +16,12 @@ def create
         ^^^^^^^^^^^^^^ Did you forget to specify an HTTP status code? [...]
         render plain: 'OK'
         ^^^^^^^^^^^^^^^^^^ Did you forget to specify an HTTP status code? [...]
+        render(:new)
+        ^^^^^^^^^^^^ Did you forget to specify an HTTP status code? [...]
+        render
+        ^^^^^^ Did you forget to specify an HTTP status code? [...]
+        render()
+        ^^^^^^^^ Did you forget to specify an HTTP status code? [...]
       end
 
       def update
@@ -33,6 +39,9 @@ def create
         render :other, status: :ok
         render 'other', status: :ok
         render plain: 'OK', status: :ok
+        render(:new, status: :unprocessable_entity)
+        render status: :ok
+        render status: :ok
       end
 
       def update
@@ -63,6 +72,7 @@ def edit
       def create
         render plain: "OK", status: :ok
         render :new, status: :unprocessable_entity
+        render status: :ok
       end
     RUBY
   end