From ec1f9e693a05eb16e64616a846953a5a6ea931b1 Mon Sep 17 00:00:00 2001 From: Josef Taylor Date: Wed, 2 Feb 2022 09:28:23 -0500 Subject: [PATCH 1/3] Updating supported versions --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 60cd02d0..d781bcda 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@ This toolkit allows interoperability between the BHoM and SAP2000. Enables creat [SAP2000 Product Website](https://www.csiamerica.com/products/sap2000) ### Known Versions of Software Supported -SAP2000 version 21 +The adapter is intended to support SAP2000 version 21 and all future versions. It is currently tested on version 23 exclusively. ### Documentation For more information about functionality see [Object Relation Table](https://github.com/BHoM/SAP2000_Toolkit/wiki/BHoM-SAP2000-Object-Relations) From 82529bf47addae1ddb79dca856c275844879781b Mon Sep 17 00:00:00 2001 From: Josef Taylor Date: Wed, 2 Feb 2022 12:01:39 -0500 Subject: [PATCH 2/3] Adding Descriptions --- SAP2000_Adapter/SAP2000Adapter.cs | 3 +++ SAP2000_Engine/Query/JoinRigidLink.cs | 6 +++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/SAP2000_Adapter/SAP2000Adapter.cs b/SAP2000_Adapter/SAP2000Adapter.cs index e953abfb..fd105ed3 100644 --- a/SAP2000_Adapter/SAP2000Adapter.cs +++ b/SAP2000_Adapter/SAP2000Adapter.cs @@ -25,6 +25,8 @@ using System.IO; using BH.oM.Adapters.SAP2000; using BH.oM.Adapter.Commands; +using System.ComponentModel; +using BH.oM.Base.Attributes; using BH.Engine.Adapter; namespace BH.Adapter.SAP2000 @@ -41,6 +43,7 @@ public partial class SAP2000Adapter : BHoMAdapter /**** Constructors ****/ /***************************************************/ + [Description("Creates an adapter supporting SAP2000v21 and later.")] public SAP2000Adapter(string filePath = "", bool active = false) { diff --git a/SAP2000_Engine/Query/JoinRigidLink.cs b/SAP2000_Engine/Query/JoinRigidLink.cs index 885c360f..f9bbdc54 100644 --- a/SAP2000_Engine/Query/JoinRigidLink.cs +++ b/SAP2000_Engine/Query/JoinRigidLink.cs @@ -26,6 +26,8 @@ using System.Collections.Generic; using System.Linq; using BH.oM.Structure.Constraints; +using BH.oM.Base.Attributes; +using System.ComponentModel; using BH.Engine.Base; namespace BH.Engine.Adapters.SAP2000 @@ -35,7 +37,9 @@ public static partial class Query /***************************************************/ /**** Public Methods ****/ /***************************************************/ - + [Description("Joins RigidLinks split by SplitRigidLink() into RigidLinks with multiple SecondaryNodes.")] + [Input("linkList", "The RigidLinks to be joined; only links containing ':::' will be joined.")] + [Output("JoinedLinks", "A list of RigidLinks with one or more SecondaryNodes")] public static List JoinRigidLink(List linkList) { Dictionary joinedList = new Dictionary(); From 7d100a94b9a12e79d9c2b9c20a78585fe30f574b Mon Sep 17 00:00:00 2001 From: Josef Taylor Date: Wed, 9 Feb 2022 14:15:44 -0500 Subject: [PATCH 3/3] make extension method --- SAP2000_Engine/Query/JoinRigidLink.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SAP2000_Engine/Query/JoinRigidLink.cs b/SAP2000_Engine/Query/JoinRigidLink.cs index f9bbdc54..7a389e68 100644 --- a/SAP2000_Engine/Query/JoinRigidLink.cs +++ b/SAP2000_Engine/Query/JoinRigidLink.cs @@ -40,7 +40,7 @@ public static partial class Query [Description("Joins RigidLinks split by SplitRigidLink() into RigidLinks with multiple SecondaryNodes.")] [Input("linkList", "The RigidLinks to be joined; only links containing ':::' will be joined.")] [Output("JoinedLinks", "A list of RigidLinks with one or more SecondaryNodes")] - public static List JoinRigidLink(List linkList) + public static List JoinRigidLink(this List linkList) { Dictionary joinedList = new Dictionary();